Skip to content

Commit

Permalink
fix: patching rules_webtesting to fix chrome path
Browse files Browse the repository at this point in the history
  • Loading branch information
meteorcloudy authored and alexeagle committed Aug 28, 2019
1 parent 2d6931c commit 97933d8
Show file tree
Hide file tree
Showing 4 changed files with 29 additions and 0 deletions.
1 change: 1 addition & 0 deletions BUILD.bazel
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,7 @@ npm_package(
srcs = glob(["*.bzl"]) + [
"BUILD.bazel",
"LICENSE",
"rules_webtesting.patch",
],
# Don't rename BUILD files as this package is not published to npm
# but is compressed in "release" below and published as a .tar.gz to GitHub
Expand Down
2 changes: 2 additions & 0 deletions packages/karma/src/package.bzl
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,8 @@ def rules_karma_dependencies():
sha256 = "f1f4d2c2f88d2beac64c82499a1e762b037966675dd892da89c87e39d72b33f6",
# Using alexeagle to workaround https://github.com/bazelbuild/rules_webtesting/issues/382
urls = ["https://github.com/alexeagle/rules_webtesting/releases/download/0.3.2/rules_webtesting.tar.gz"],
patches = ["@build_bazel_rules_nodejs//:rules_webtesting.patch"],
patch_args = ["-p1"],
)

def _maybe(repo_rule, name, **kwargs):
Expand Down
2 changes: 2 additions & 0 deletions packages/protractor/src/package.bzl
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,8 @@ def npm_bazel_protractor_dependencies():
sha256 = "f1f4d2c2f88d2beac64c82499a1e762b037966675dd892da89c87e39d72b33f6",
# Using alexeagle to workaround https://github.com/bazelbuild/rules_webtesting/issues/382
urls = ["https://github.com/alexeagle/rules_webtesting/releases/download/0.3.2/rules_webtesting.tar.gz"],
patches = ["@build_bazel_rules_nodejs//:rules_webtesting.patch"],
patch_args = ["-p1"],
)

def _maybe(repo_rule, name, **kwargs):
Expand Down
24 changes: 24 additions & 0 deletions rules_webtesting.patch
Original file line number Diff line number Diff line change
@@ -0,0 +1,24 @@
commit 324d178e836b8f93c93321312e890176c986147a
Author: Yun Peng <[email protected]>
Date: Tue Aug 27 13:42:35 2019 +0200

Fix chromium rule and definition for Windows

1. Write output dir of named_files in metadata. This could help us locate named
files in runfiles, because they are under the tree artifact of the output dir.

2. Fix the chromium path for Windows

diff --git a/third_party/chromium/BUILD.bazel b/third_party/chromium/BUILD.bazel
index 384d018..2cbbb4a 100644
--- a/third_party/chromium/BUILD.bazel
+++ b/third_party/chromium/BUILD.bazel
@@ -33,7 +33,7 @@ web_test_archive(
"CHROMIUM": "chrome-mac/Chromium.app/Contents/MacOS/chromium",
},
"//common/conditions:windows": {
- "CHROMIUM": "chrome-win32/chrome.exe",
+ "CHROMIUM": "chrome-win/chrome.exe",
},
}),
visibility = ["//browsers:__subpackages__"],

0 comments on commit 97933d8

Please sign in to comment.