Skip to content

Commit

Permalink
chore: remove tsc_wrapped_deps compatibility (#1100)
Browse files Browse the repository at this point in the history
This was introduced a year ago in https://github.com/bazelbuild/rules_typescript/pull/276/files to help avoid a breaking change to rxjs. They no longer need it, and very unlikely anyone else ever used it.

BREAKING CHANGE:

A compatibility layer was removed. See discussion in #1086

Fixes #1086
  • Loading branch information
alexeagle authored and gregmagolan committed Sep 6, 2019
1 parent e9a2e34 commit 5e98bda
Showing 1 changed file with 0 additions and 13 deletions.
13 changes: 0 additions & 13 deletions packages/typescript/src/internal/ts_repositories.bzl
Original file line number Diff line number Diff line change
Expand Up @@ -29,19 +29,6 @@ def ts_setup_workspace():
# 0.16.8: ng_package fix for packaging binary files
check_rules_nodejs_version("0.16.8")

# Included here for backward compatability for downstream repositories
# that use @build_bazel_rules_typescript_tsc_wrapped_deps such as rxjs.
# @build_bazel_rules_typescript_tsc_wrapped_deps is not used locally.
yarn_install(
name = "build_bazel_rules_typescript_tsc_wrapped_deps",
package_json = "@npm_bazel_typescript//internal:tsc_wrapped/package.json",
yarn_lock = "@npm_bazel_typescript//internal:tsc_wrapped/yarn.lock",
# Do not symlink node_modules as when used in downstream repos we should not create
# node_modules folders in the @npm_bazel_typescript external repository. This is
# not supported by managed_directories.
symlink_node_modules = False,
)

yarn_install(
name = "build_bazel_rules_typescript_devserver_deps",
package_json = "@npm_bazel_typescript//internal/devserver:package.json",
Expand Down

0 comments on commit 5e98bda

Please sign in to comment.