fix(typescript): add peerDependency on typescript

Set it to 3.0 or greater. This lets us drop some e2e testing which was taking a long time on CI. Also add e2e testing for TS 3.6 which was just released. Note that typescript doesn't do semver so it's possible that something breaks before 4.0. If users report that, we'll have to re-publish with a narrowed range.
bazel-contrib · Aug 29, 2019 · 48c5088 · 48c5088
1 parent 2c947e2
commit 48c5088
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/e2e/BUILD.bazel b/e2e/BUILD.bazel
@@ -134,15 +134,13 @@ e2e_integration_test(
     },
     workspace_files = "@e2e_typescript//:all_files",
 ) for tsc_version in [
-    "2.7.x",
-    "2.8.x",
-    "2.9.x",
     "3.0.x",
     "3.1.x",
     "3.2.x",
     "3.3.x",
     "3.4.x",
     "3.5.x",
+    "3.6.x",
 ]]
 
 e2e_integration_test(

diff --git a/packages/typescript/src/package.json b/packages/typescript/src/package.json
@@ -21,6 +21,10 @@
         "ts_auto_deps": "./ts_auto_deps/ts_auto_deps.js",
         "tsc_wrapped": "./internal/tsc_wrapped/tsc_wrapped.js"
     },
+    "//": "note that typescript doesn't follow semver, so technically anything 3.6 or higher might break us",
+    "peerDependencies": {
+        "typescript": ">=3.0.0 <4.0"
+    },
     "dependencies": {
         "protobufjs": "6.8.8",
         "semver": "5.6.0",