chore: move karma_web_test to concatjs (#2313)

* chore: move karma_web_test to concatjs BREAKING CHANGE: `packages/karma:package.bzl` is gone, in your WORKSPACE replace ``` load("//packages/karma:package.bzl", "npm_bazel_karma_dependencies") npm_bazel_karma_dependencies() ``` with the equivalent ``` http_archive( name = "io_bazel_rules_webtesting", sha256 = "9bb461d5ef08e850025480bab185fd269242d4e533bca75bfb748001ceb343c3", urls = ["https://github.com/bazelbuild/rules_webtesting/releases/download/0.3.3/rules_webtesting.tar.gz"], ) ``` Then in BUILD files replace `load("@npm//@bazel/karma:index.bzl", "karma_web_test_suite")` with `load("@npm//@bazel/concatjs:index.bzl", "concatjs_web_test_suite")` finally drop npm dependencies on `@bazel/karma` and depend on `@bazel/concatjs` instead * concatjs_web back to karma_web
bazel-contrib · Dec 2, 2020 · 252b8e5 · 252b8e5
1 parent f01e319
commit 252b8e5
Show file tree

Hide file tree

Showing 70 changed files with 248 additions and 1,130 deletions.
diff --git a/WORKSPACE b/WORKSPACE
@@ -140,14 +140,6 @@ cypress_repository(
     fail_on_error = False,
 )
 
-#
-# Install @bazel/karma dependencies
-#
-
-load("//packages/karma:package.bzl", "npm_bazel_karma_dependencies")
-
-npm_bazel_karma_dependencies()
-
 # Setup the rules_webtesting toolchain
 load("@io_bazel_rules_webtesting//web:repositories.bzl", "web_test_repositories")
 

diff --git a/commitlint.config.js b/commitlint.config.js
@@ -13,7 +13,6 @@ module.exports = {
         'cypress',
         'examples',
         'jasmine',
-        'karma',
         'labs',
         'protractor',
         'rollup',

diff --git a/docs/BUILD.bazel b/docs/BUILD.bazel
@@ -76,7 +76,6 @@ rules_nodejs_docs(
         "Concatjs": "//packages/concatjs:README.md",
         "Cypress": "//packages/cypress:README.md",
         "Jasmine": "//packages/jasmine:README.md",
-        "Karma": "//packages/karma:README.md",
         "Labs": "//packages/labs:README.md",
         "Protractor": "//packages/protractor:README.md",
         "Rollup": "//packages/rollup:README.md",

diff --git a/docs/Karma.html b/docs/Karma.html
diff --git a/docs/Karma.md b/docs/Karma.md
diff --git a/examples/BUILD.bazel b/examples/BUILD.bazel
@@ -20,7 +20,6 @@ example_integration_test(
     npm_packages = {
         "//packages/angular:npm_package": "@bazel/angular",
         "//packages/concatjs:npm_package": "@bazel/concatjs",
-        "//packages/karma:npm_package": "@bazel/karma",
         "//packages/protractor:npm_package": "@bazel/protractor",
         "//packages/rollup:npm_package": "@bazel/rollup",
         "//packages/terser:npm_package": "@bazel/terser",
@@ -46,7 +45,6 @@ example_integration_test(
     timeout = "long",
     npm_packages = {
         "//packages/concatjs:npm_package": "@bazel/concatjs",
-        "//packages/karma:npm_package": "@bazel/karma",
         "//packages/protractor:npm_package": "@bazel/protractor",
         "//packages/rollup:npm_package": "@bazel/rollup",
         "//packages/terser:npm_package": "@bazel/terser",
@@ -142,7 +140,7 @@ example_integration_test(
 example_integration_test(
     name = "examples_web_testing",
     npm_packages = {
-        "//packages/karma:npm_package": "@bazel/karma",
+        "//packages/concatjs:npm_package": "@bazel/concatjs",
         "//packages/typescript:npm_package": "@bazel/typescript",
     },
 )
@@ -190,7 +188,6 @@ example_integration_test(
     timeout = "long",
     npm_packages = {
         "//packages/concatjs:npm_package": "@bazel/concatjs",
-        "//packages/karma:npm_package": "@bazel/karma",
         "//packages/labs:npm_package": "@bazel/labs",
         "//packages/protractor:npm_package": "@bazel/protractor",
         "//packages/rollup:npm_package": "@bazel/rollup",

diff --git a/examples/angular/WORKSPACE b/examples/angular/WORKSPACE
@@ -59,10 +59,12 @@ load("@npm//@bazel/protractor:package.bzl", "npm_bazel_protractor_dependencies")
 
 npm_bazel_protractor_dependencies()
 
-# Load @bazel/karma dependencies
-load("@npm//@bazel/karma:package.bzl", "npm_bazel_karma_dependencies")
-
-npm_bazel_karma_dependencies()
+# Load karma_web_test dependencies
+http_archive(
+    name = "io_bazel_rules_webtesting",
+    sha256 = "9bb461d5ef08e850025480bab185fd269242d4e533bca75bfb748001ceb343c3",
+    urls = ["https://github.com/bazelbuild/rules_webtesting/releases/download/0.3.3/rules_webtesting.tar.gz"],
+)
 
 # Setup the rules_webtesting toolchain
 load("@io_bazel_rules_webtesting//web:repositories.bzl", "web_test_repositories")

diff --git a/examples/angular/package.json b/examples/angular/package.json
@@ -42,7 +42,6 @@
         "@bazel/buildifier": "^3.5.0",
         "@bazel/concatjs": "^2.2.2",
         "@bazel/ibazel": "^0.13.2",
-        "@bazel/karma": "^2.2.2",
         "@bazel/protractor": "^2.2.2",
         "@bazel/rollup": "^2.2.2",
         "@bazel/terser": "^2.2.2",

diff --git a/examples/angular/src/app/hello-world/BUILD.bazel b/examples/angular/src/app/hello-world/BUILD.bazel
@@ -1,5 +1,5 @@
 load("@io_bazel_rules_sass//:defs.bzl", "multi_sass_binary")
-load("@npm//@bazel/karma:index.bzl", "karma_web_test_suite")
+load("@npm//@bazel/concatjs:index.bzl", "karma_web_test_suite")
 load("@npm//@bazel/typescript:index.bzl", "ts_library")
 load("//tools:angular_ts_library.bzl", "ng_ts_library")
 

diff --git a/examples/angular/yarn.lock b/examples/angular/yarn.lock
@@ -883,13 +883,6 @@
   resolved "https://registry.yarnpkg.com/@bazel/ibazel/-/ibazel-0.13.2.tgz#eb914c41c66af4606db786457a7b130634355e8f"
   integrity sha512-q5fGwjTY76MLNcYpF2zEu/y1Clu4DjdjhvJM9+yDKc3+3mBlbX+uiMJYiCz5b0oSYdJTlw1QSRptTYA7CID8EQ==
 
-"@bazel/karma@^2.2.2":
-  version "2.2.2"
-  resolved "https://registry.yarnpkg.com/@bazel/karma/-/karma-2.2.2.tgz#89470c42c527973bb59a02527b55ef9225dcbfc0"
-  integrity sha512-V5y2N5d6RXde/4TQ8UcNg3IBdLx1tob6drYlHB7nYF3soShucTOfvEyENCLzn4LVeFgTrR8gdob5b3TzvYUCCw==
-  dependencies:
-    tmp "0.1.0"
-
 "@bazel/protractor@^2.2.2":
   version "2.2.2"
   resolved "https://registry.yarnpkg.com/@bazel/protractor/-/protractor-2.2.2.tgz#0660837a193994ee349e15cb022de76f3262af5e"

diff --git a/examples/angular_view_engine/WORKSPACE b/examples/angular_view_engine/WORKSPACE
@@ -53,10 +53,12 @@ load("@npm//@bazel/protractor:package.bzl", "npm_bazel_protractor_dependencies")
 
 npm_bazel_protractor_dependencies()
 
-# Load @bazel/karma dependencies
-load("@npm//@bazel/karma:package.bzl", "npm_bazel_karma_dependencies")
-
-npm_bazel_karma_dependencies()
+# Load karma dependencies
+http_archive(
+    name = "io_bazel_rules_webtesting",
+    sha256 = "9bb461d5ef08e850025480bab185fd269242d4e533bca75bfb748001ceb343c3",
+    urls = ["https://github.com/bazelbuild/rules_webtesting/releases/download/0.3.3/rules_webtesting.tar.gz"],
+)
 
 # Setup the rules_webtesting toolchain
 load("@io_bazel_rules_webtesting//web:repositories.bzl", "web_test_repositories")

diff --git a/examples/angular_view_engine/package.json b/examples/angular_view_engine/package.json
@@ -37,7 +37,6 @@
         "@bazel/buildifier": "^3.5.0",
         "@bazel/ibazel": "^0.13.2",
         "@bazel/concatjs": "^2.2.2",
-        "@bazel/karma": "^2.2.2",
         "@bazel/protractor": "^2.2.2",
         "@bazel/rollup": "^2.2.2",
         "@bazel/terser": "^2.2.2",

diff --git a/examples/angular_view_engine/src/app/hello-world/BUILD.bazel b/examples/angular_view_engine/src/app/hello-world/BUILD.bazel
@@ -1,5 +1,5 @@
 load("@io_bazel_rules_sass//:defs.bzl", "sass_binary")
-load("@npm//@bazel/karma:index.bzl", "karma_web_test_suite")
+load("@npm//@bazel/concatjs:index.bzl", "karma_web_test_suite")
 load("@npm//@bazel/typescript:index.bzl", "ts_library")
 load("@npm_angular_bazel//:index.bzl", "ng_module")
 

diff --git a/examples/angular_view_engine/yarn.lock b/examples/angular_view_engine/yarn.lock
@@ -833,13 +833,6 @@
   resolved "https://registry.yarnpkg.com/@bazel/ibazel/-/ibazel-0.13.2.tgz#eb914c41c66af4606db786457a7b130634355e8f"
   integrity sha512-q5fGwjTY76MLNcYpF2zEu/y1Clu4DjdjhvJM9+yDKc3+3mBlbX+uiMJYiCz5b0oSYdJTlw1QSRptTYA7CID8EQ==
 
-"@bazel/karma@^2.2.2":
-  version "2.2.2"
-  resolved "https://registry.yarnpkg.com/@bazel/karma/-/karma-2.2.2.tgz#89470c42c527973bb59a02527b55ef9225dcbfc0"
-  integrity sha512-V5y2N5d6RXde/4TQ8UcNg3IBdLx1tob6drYlHB7nYF3soShucTOfvEyENCLzn4LVeFgTrR8gdob5b3TzvYUCCw==
-  dependencies:
-    tmp "0.1.0"
-
 "@bazel/protractor@^2.2.2":
   version "2.2.2"
   resolved "https://registry.yarnpkg.com/@bazel/protractor/-/protractor-2.2.2.tgz#0660837a193994ee349e15cb022de76f3262af5e"

diff --git a/examples/protocol_buffers/BUILD.bazel b/examples/protocol_buffers/BUILD.bazel
@@ -1,5 +1,4 @@
-load("@npm//@bazel/concatjs:index.bzl", "concatjs_devserver")
-load("@npm//@bazel/karma:index.bzl", "karma_web_test_suite")
+load("@npm//@bazel/concatjs:index.bzl", "concatjs_devserver", "karma_web_test_suite")
 load("@npm//@bazel/labs:index.bzl", "ts_proto_library")
 load("@npm//@bazel/protractor:index.bzl", "protractor_web_test_suite")
 load("@npm//@bazel/rollup:index.bzl", "rollup_bundle")