Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add override path for archiver_flags in rules based toolchain #331

Open
keith opened this issue Jan 29, 2025 · 1 comment
Open

Add override path for archiver_flags in rules based toolchain #331

keith opened this issue Jan 29, 2025 · 1 comment

Comments

@keith
Copy link
Member

keith commented Jan 29, 2025

Currently this toolchain assumes that if you're targeting macOS you will always use llvm-libtool-darwin:

"@platforms//os:macos": ["-static"],

Technically this is not a requirement and using llvm-ar is fine. It seems like maybe this configuration decision should be more flexible than forcing llvm-libtool-darwin if you ever target macOS

@armandomontanez armandomontanez self-assigned this Jan 29, 2025
@keith
Copy link
Member Author

keith commented Feb 4, 2025

another practical reason to allow using ar on darwin is llvm-libtool-darwin warns about things like multiple object files with the same name in the archive, without that actually being an issue in most cases

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants