can not build on windows

[lainswork]

when i build reclient

Bazel uses ml64 to compile S file, but in reality, I have specified the compiler as GCC
Ultimately, ml64 was unable to parse assembly files from the gcc specification

[daniel-sudz]

@gkousik I am able to reproduce this issue. Would upstream accept a PR for a fix?

[bentekkie]

We use the llvm clang-cl toolchain to compile on windows.

Could you try the build after following https://bazel.build/configure/windows#clang

[bentekkie]

Actually I reproduced it locally, will work on a fix

[bentekkie]

f7132ba should fix this, can you confirm?

[bentekkie]

You will need the clang-cl toolchain installed on your machine

[daniel-sudz]

You will need the clang-cl toolchain installed on your machine

I'm currently having some trouble getting bazel to find my clang-cl but this is unrelated to reclient. I pulled llvm from choco under C:\\Program Files\\LLVM\\bin and put it on my action-env path but something still seems wrong.

Anyways I will debug this for a bit and let you know if I still need something. Thanks again for the help!

setting BAZEL_LLVM explicitly seems to do the trick.

[daniel-sudz]

f7132ba should fix this, can you confirm?

I think I'm seeing an issue similar to bazelbuild/bazel#17863 now. Looking into it.

ERROR: C:/users/containeradministrator/_bazel_containeradministrator/sd2lufjt/external/com_github_gflags_gflags/BUILD:18:15: Compiling src/windows_port.cc failed: undeclared inclusion(s) in rule '@com_github_gflags_gflags//:gflags':
this rule is missing dependency declarations for the following files included by 'src/windows_port.cc':
  'C:/Program Files/LLVM/lib/clang/18/include/vadefs.h'
  'C:/Program Files/LLVM/lib/clang/18/include/stdarg.h'
  'C:/Program Files/LLVM/lib/clang/18/include/__stdarg___gnuc_va_list.h'
  'C:/Program Files/LLVM/lib/clang/18/include/__stdarg_va_list.h'
  'C:/Program Files/LLVM/lib/clang/18/include/__stdarg_va_arg.h'
  'C:/Program Files/LLVM/lib/clang/18/include/__stdarg___va_copy.h'
  'C:/Program Files/LLVM/lib/clang/18/include/__stdarg_va_copy.h'
  'C:/Program Files/LLVM/lib/clang/18/include/stdarg.h'
  'C:/Program Files/LLVM/lib/clang/18/include/stdarg.h'
  'C:/Program Files/LLVM/lib/clang/18/include/stddef.h'
  'C:/Program Files/LLVM/lib/clang/18/include/__stddef_ptrdiff_t.h'
  'C:/Program Files/LLVM/lib/clang/18/include/__stddef_size_t.h'
  'C:/Program Files/LLVM/lib/clang/18/include/__stddef_wchar_t.h'
  'C:/Program Files/LLVM/lib/clang/18/include/__stddef_null.h'
  'C:/Program Files/LLVM/lib/clang/18/include/__stddef_nullptr_t.h'
  'C:/Program Files/LLVM/lib/clang/18/include/__stddef_max_align_t.h'
  'C:/Program Files/LLVM/lib/clang/18/include/__stddef_offsetof.h'
  'C:/Program Files/LLVM/lib/clang/18/include/limits.h'
  'C:/Program Files/LLVM/lib/clang/18/include/stdarg.h'
  'C:/Program Files/LLVM/lib/clang/18/include/inttypes.h'
  'C:/Program Files/LLVM/lib/clang/18/include/stdint.h'
Target //cmd/scandeps:scandeps_server failed to build
INFO: Elapsed time: 11.929s, Critical Path: 1.53s
INFO: 8 processes: 8 internal.
FAILED: Build did NOT complete successfully

[daniel-sudz]

@bentekkie created new issue in https://issues.chromium.org/issues/345627618 to bump bazel version.

[bentekkie]

Closing this as we have a working GitHub actions build now