Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix googletest target name #24615

Closed
wants to merge 1 commit into from
Closed

Conversation

ericriff
Copy link
Contributor

@ericriff ericriff commented Dec 9, 2024

I was following the tutorial and hit a wall here.

 bazel test //test:hello-test
ERROR: /home/eriff/.cache/bazel/_bazel_eriff/f6bb6ff4e6e38165bb9ceee09de6c8af/external/googletest+/BUILD.bazel: no such target '@@googletest+//:main': target 'main' not declared in package '' defined by /home/eriff/.cache/bazel/_bazel_eriff/f6bb6ff4e6e38165bb9ceee09de6c8af/external/googletest+/BUILD.bazel
ERROR: /home/eriff/repos/bazel-examples/cpp-tutorial/stage3/test/BUILD:1:8: no such target '@@googletest+//:main': target 'main' not declared in package '' defined by /home/eriff/.cache/bazel/_bazel_eriff/f6bb6ff4e6e38165bb9ceee09de6c8af/external/googletest+/BUILD.bazel and referenced by '//test:hello-test'
ERROR: Analysis of target '//test:hello-test' failed; build aborted: Analysis failed

Turns out the target name was wrong

Copy link

google-cla bot commented Dec 9, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@github-actions github-actions bot added team-Documentation Documentation improvements that cannot be directly linked to other team labels awaiting-review PR is awaiting review from an assigned reviewer labels Dec 9, 2024
@ericriff ericriff closed this Dec 9, 2024
@ericriff ericriff reopened this Dec 9, 2024
@github-actions github-actions bot added awaiting-review PR is awaiting review from an assigned reviewer and removed awaiting-review PR is awaiting review from an assigned reviewer labels Dec 9, 2024
@fweikert fweikert added awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally and removed awaiting-review PR is awaiting review from an assigned reviewer labels Dec 10, 2024
@iancha1992 iancha1992 added the team-OSS Issues for the Bazel OSS team: installation, release processBazel packaging, website label Dec 10, 2024
@github-actions github-actions bot removed the awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally label Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team-Documentation Documentation improvements that cannot be directly linked to other team labels team-OSS Issues for the Bazel OSS team: installation, release processBazel packaging, website
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants