Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Bazel's embedded JDK to 23.0.1 #24609

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Conversation

fmeum
Copy link
Collaborator

@fmeum fmeum commented Dec 9, 2024

In addition to performance improvements, this JDK release contains a fix for https://bugs.openjdk.org/browse/JDK-8330077, which allows --watchfs to handle a configurable number of changes to a watched path rather than maxing out at 500.

Windows arm64 can switch to Zulu JDK 21.

Since async-profiler is released very rarely (last release in January) and the latest release is not compatible with JDK 23, this PR consumes a recent nightly release instead. This has the side effect of removing a bit of bloat from the server jar as it no longer contains async profiler's native library for all OSes/arches.

@fmeum fmeum force-pushed the jdk-23 branch 3 times, most recently from 60c3b6b to 665700c Compare December 9, 2024 23:16
In addition to performance improvements, this JDK release contains a fix for https://bugs.openjdk.org/browse/JDK-8330077, which allows `--watchfs` to handle a configurable number of changes to a watched path rather than maxing out at 500.

Windows arm64 can switch to Zulu JDK 21.
@fmeum fmeum requested a review from meteorcloudy December 13, 2024 10:48
@fmeum fmeum marked this pull request as ready for review December 13, 2024 10:48
@github-actions github-actions bot added team-Performance Issues for Performance teams awaiting-review PR is awaiting review from an assigned reviewer labels Dec 13, 2024
@meteorcloudy meteorcloudy added awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally and removed awaiting-review PR is awaiting review from an assigned reviewer labels Dec 13, 2024
@fmeum
Copy link
Collaborator Author

fmeum commented Dec 13, 2024

@bazel-io flag 8.1.0

@bazel-io bazel-io added the potential release blocker Flagged by community members using "@bazel-io flag". Should be added to a release blocker milestone label Dec 13, 2024
@iancha1992
Copy link
Member

@bazel-io fork 8.1.0

@bazel-io bazel-io removed the potential release blocker Flagged by community members using "@bazel-io flag". Should be added to a release blocker milestone label Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally team-Performance Issues for Performance teams
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants