Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: Flip --enable_workspace to false #23253

Closed
wants to merge 47 commits into from
Closed

WIP: Flip --enable_workspace to false #23253

wants to merge 47 commits into from

Conversation

meteorcloudy
Copy link
Member

@meteorcloudy meteorcloudy requested a review from a team as a code owner August 9, 2024 16:06
@meteorcloudy meteorcloudy requested review from gregestren and removed request for a team August 9, 2024 16:06
@meteorcloudy meteorcloudy marked this pull request as draft August 9, 2024 16:06
@github-actions github-actions bot added team-Configurability platforms, toolchains, cquery, select(), config transitions awaiting-review PR is awaiting review from an assigned reviewer labels Aug 9, 2024
@meteorcloudy meteorcloudy force-pushed the disable_workspace_java_unit branch from 7b79fca to a922876 Compare August 12, 2024 10:33
@meteorcloudy meteorcloudy mentioned this pull request Aug 13, 2024
Closed
13 tasks
@meteorcloudy meteorcloudy force-pushed the disable_workspace_java_unit branch 3 times, most recently from 3eb95d6 to 8f6bd8a Compare August 14, 2024 12:38
@meteorcloudy
Record failed tests
87d6a76
@meteorcloudy
Flip ---enable_workspace to false
7587323
@meteorcloudy
Register toolchains in MODULE.bazel
fba9a49
@meteorcloudy
Enable bzlmod for AnalysisTestCase.java
a79af22
@meteorcloudy
Fix //src/test/java/com/google/devtools/build/lib/analysis:AnalysisTests
dc84d88
@meteorcloudy
Fix //src/test/java/com/google/devtools/build/lib/analysis/config:Con…
bccb571 
…figTests
@meteorcloudy
Fix //src/test/java/com/google/devtools/build/lib/analysis:RunfilesRe…
bb8b51d 
…poMappingManifestTest
@meteorcloudy
Fix //src/test/java/com/google/devtools/build/lib/bazel/repository/st…
e4c7f8d 
…arlark:StarlarkTests
@meteorcloudy
Enable workspace for //src/test/java/com/google/devtools/build/lib/ba…
b6ef3e4 
…zel/rules/android:AndroidTests
@meteorcloudy
Fix withAdditionalMappings to deal with null
19cdace
@meteorcloudy
Fix //src/test/java/com/google/devtools/build/lib/pkgcache:LoadingPha…
5c70115 
…seRunnerTest
@meteorcloudy
Fix //src/test/java/com/google/devtools/build/lib/pkgcache:TargetPatt…
4e586fe 
…ernEvaluatorTest
@meteorcloudy
Fix //src/test/java/com/google/devtools/build/lib/query2/aquery:Actio…
534e923 
…nGraphQueryTest
@meteorcloudy
Fix //src/test/java/com/google/devtools/build/lib/query2/engine:AllTests
bc1d1e6
@meteorcloudy
Fix //src/test/java/com/google/devtools/build/lib/repository:Reposito…
4d069b3 
…ryTests
@meteorcloudy
Fix //src/test/java/com/google/devtools/build/lib/rules/android:Andro…
ba45f7f 
…idBinaryTest
@meteorcloudy
Fix //src/test/java/com/google/devtools/build/lib/rules/cpp:CcCommonTest
4066914
@meteorcloudy
Fixed //src/test/java/com/google/devtools/build/lib/rules/cpp:Compile…
27fe4d0 
…BuildVariablesTest
@meteorcloudy
Fix //src/test/java/com/google/devtools/build/lib/rules/cpp:Libraries…
1e31d07 
…ToLinkCollectorTest
@meteorcloudy
Fix //src/test/java/com/google/devtools/build/lib/runtime:ConfigComma…
9f6a05b 
…ndTest
@meteorcloudy
Fix //src/test/java/com/google/devtools/build/lib/skyframe/packages:B…
09001c7 
…azelPackageLoaderTest
@meteorcloudy
Fix toolchain registration tests
49c9220
@meteorcloudy
Fix //src/test/java/com/google/devtools/build/lib/skyframe:BuiltinsIn…
ccc50fb 
…jectionTest
@meteorcloudy
Fix //src/test/java/com/google/devtools/build/lib/skyframe:BzlLoadFun…
e4a656d 
…ctionTest
@meteorcloudy
Fix //src/test/java/com/google/devtools/build/lib/skyframe:Containing…
2276675 
…PackageLookupFunctionTest
@meteorcloudy
Fix //src/test/java/com/google/devtools/build/lib/skyframe:FileFuncti…
55328c6 
…onTest
@meteorcloudy
Fix //src/test/java/com/google/devtools/build/lib/skyframe:LocalRepos…
ee227c7 
…itoryLookupFunctionTest
@meteorcloudy
Fix //src/test/java/com/google/devtools/build/lib/skyframe:PackageFun…
74b13e9 
…ctionTest
@meteorcloudy
Fix //src/test/java/com/google/devtools/build/lib/skyframe:Repository…
0104efb 
…MappingFunctionTest
@meteorcloudy
Fix //src/test/java/com/google/devtools/build/lib/skyframe:WorkspaceN…
4323f44 
…ameFunctionTest
@meteorcloudy
Fix //src/test/java/com/google/devtools/build/lib/starlark:BindTest
00f590c
@meteorcloudy
Fix //src/test/java/com/google/devtools/build/lib/starlark:StarlarkRu…
8572ad3 
…leClassFunctionsTest
@meteorcloudy
Fix most of //src/test/java/com/google/devtools/build/lib/starlark:St…
d676b87 
…arlarkTests
@meteorcloudy
Fix //src/test/java/com/google/devtools/build/lib/starlark:StarlarkTests
fced378
@meteorcloudy
Fix broken tests
bd73685
@meteorcloudy
record fixed tests
0a40e3c
@meteorcloudy
Fix apple tests
428f6d1
@meteorcloudy
Fix //src/test/java/com/google/devtools/build/lib/skyframe:PackageLoo…
5219842 
…kupFunctionTest
@meteorcloudy meteorcloudy force-pushed the disable_workspace_java_unit branch from 426f396 to 5219842 Compare August 19, 2024 09:12
@meteorcloudy meteorcloudy force-pushed the disable_workspace_java_unit branch 2 times, most recently from ab7b985 to 28f76ac Compare August 19, 2024 12:44
@meteorcloudy meteorcloudy force-pushed the disable_workspace_java_unit branch from cc4d663 to 161c4ae Compare August 19, 2024 12:46
copybara-service bot pushed a commit that referenced this pull request Aug 19, 2024
@meteorcloudy @copybara-github
Enable Bzlmod in AnalysisTestCase.java
f848b06 
Working towards: #19824

Related: #23023

Part of: #23253

PiperOrigin-RevId: 664876902
Change-Id: I8386b13fd12f5d4fb0599c0142df668b0c4a7f74
copybara-service bot pushed a commit that referenced this pull request Aug 27, 2024
@meteorcloudy @copybara-github
Flip --enable_workspace to false
5881c38 
- Most test cases have migrated from WORKSPACE to MODULE.bazel
- Some test cases still enable WORKSPACE because they test WORKSPACE functionalities.

Part of #23253

Fixes #19824
Working towards #23023

PiperOrigin-RevId: 667901985
Change-Id: I35ee8050d835a62fed4cd7e6637bd0616766f3c4
@meisterT
Copy link
Member

meisterT commented Sep 5, 2024

I assume this can be closed?

@github-actions github-actions bot removed the awaiting-review PR is awaiting review from an assigned reviewer label Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gregestren gregestren Awaiting requested review from gregestren gregestren is a code owner automatically assigned from bazelbuild/configurability

@comius comius Awaiting requested review from comius comius will be requested when the pull request is marked ready for review comius is a code owner

@pzembrod pzembrod Awaiting requested review from pzembrod pzembrod will be requested when the pull request is marked ready for review pzembrod is a code owner

@trybka trybka Awaiting requested review from trybka trybka will be requested when the pull request is marked ready for review trybka is a code owner

@ahumesky ahumesky Awaiting requested review from ahumesky ahumesky will be requested when the pull request is marked ready for review ahumesky is a code owner

@ted-xie ted-xie Awaiting requested review from ted-xie ted-xie will be requested when the pull request is marked ready for review ted-xie is a code owner

Assignees
No one assigned
Labels
team-Configurability platforms, toolchains, cquery, select(), config transitions
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@meteorcloudy @meisterT