Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support clang-16 install directory on Windows #19391

Closed
wants to merge 1 commit into from

Conversation

ohodson
Copy link
Contributor

@ohodson ohodson commented Sep 1, 2023

Clang install on Windows started using just the major version number in the install path rather than the full version number.

Fixes #17863

Clang install on Windows started using just the major version
number in the install path rather than the full version number.

Fixes bazelbuild#17863
@github-actions github-actions bot added awaiting-review PR is awaiting review from an assigned reviewer team-Rules-CPP Issues for C++ rules labels Sep 1, 2023
@fmeum
Copy link
Collaborator

fmeum commented Sep 1, 2023

CC @meteorcloudy

Copy link
Member

@meteorcloudy meteorcloudy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@meteorcloudy meteorcloudy added awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally and removed awaiting-review PR is awaiting review from an assigned reviewer labels Sep 1, 2023
@copybara-service copybara-service bot closed this in 0377bad Sep 4, 2023
@github-actions github-actions bot removed the awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally label Sep 4, 2023
@ohodson ohodson deleted the ohodson/llvm-clang-16 branch September 4, 2023 08:46
bazel-io pushed a commit to bazel-io/bazel that referenced this pull request Sep 6, 2023
Clang install on Windows started using just the major version number in the install path rather than the full version number.

Fixes bazelbuild#17863

Closes bazelbuild#19391.

PiperOrigin-RevId: 562480023
Change-Id: Iebd5d3cedff48739747fa8668d56ff8f1d9350b9
iancha1992 pushed a commit that referenced this pull request Sep 7, 2023
Clang install on Windows started using just the major version number in
the install path rather than the full version number.

Fixes #17863

Closes #19391.

Commit
0377bad

PiperOrigin-RevId: 562480023
Change-Id: Iebd5d3cedff48739747fa8668d56ff8f1d9350b9

Co-authored-by: Orion Hodson <[email protected]>
keith pushed a commit to keith/bazel that referenced this pull request Sep 8, 2023
Clang install on Windows started using just the major version number in
the install path rather than the full version number.

Fixes bazelbuild#17863

Closes bazelbuild#19391.

Commit
bazelbuild@0377bad

PiperOrigin-RevId: 562480023
Change-Id: Iebd5d3cedff48739747fa8668d56ff8f1d9350b9

Co-authored-by: Orion Hodson <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team-Rules-CPP Issues for C++ rules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong include path to Clang 16 on Windows
3 participants