-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support clang-16 install directory on Windows #19391
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Clang install on Windows started using just the major version number in the install path rather than the full version number. Fixes bazelbuild#17863
github-actions
bot
added
awaiting-review
PR is awaiting review from an assigned reviewer
team-Rules-CPP
Issues for C++ rules
labels
Sep 1, 2023
meteorcloudy
approved these changes
Sep 1, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
meteorcloudy
added
awaiting-PR-merge
PR has been approved by a reviewer and is ready to be merge internally
and removed
awaiting-review
PR is awaiting review from an assigned reviewer
labels
Sep 1, 2023
github-actions
bot
removed
the
awaiting-PR-merge
PR has been approved by a reviewer and is ready to be merge internally
label
Sep 4, 2023
bazel-io
pushed a commit
to bazel-io/bazel
that referenced
this pull request
Sep 6, 2023
Clang install on Windows started using just the major version number in the install path rather than the full version number. Fixes bazelbuild#17863 Closes bazelbuild#19391. PiperOrigin-RevId: 562480023 Change-Id: Iebd5d3cedff48739747fa8668d56ff8f1d9350b9
iancha1992
pushed a commit
that referenced
this pull request
Sep 7, 2023
Clang install on Windows started using just the major version number in the install path rather than the full version number. Fixes #17863 Closes #19391. Commit 0377bad PiperOrigin-RevId: 562480023 Change-Id: Iebd5d3cedff48739747fa8668d56ff8f1d9350b9 Co-authored-by: Orion Hodson <[email protected]>
keith
pushed a commit
to keith/bazel
that referenced
this pull request
Sep 8, 2023
Clang install on Windows started using just the major version number in the install path rather than the full version number. Fixes bazelbuild#17863 Closes bazelbuild#19391. Commit bazelbuild@0377bad PiperOrigin-RevId: 562480023 Change-Id: Iebd5d3cedff48739747fa8668d56ff8f1d9350b9 Co-authored-by: Orion Hodson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clang install on Windows started using just the major version number in the install path rather than the full version number.
Fixes #17863