Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add blake3 NEON instructions on linux arm64 #19384

Closed
wants to merge 4 commits into from
Closed

Add blake3 NEON instructions on linux arm64 #19384

Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
36ad037
Disable using NEON instructions on linux arm64
mauriciogg Aug 31, 2023
380762f
Update blake3.BUILD
mauriciogg Aug 31, 2023
8b3ed22
Update blake3.BUILD
mauriciogg Aug 31, 2023
a8a8182
Update blake3.BUILD
mauriciogg Sep 1, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions third_party/blake3/blake3.BUILD
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,9 @@ cc_library(
# lacking the headers to compile AVX512.
"-DBLAKE3_NO_AVX512",
],
"@bazel_tools//src/conditions:linux_aarch64": [
"-DBLAKE3_USE_NEON=0",
],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't we instead include c/blake3_neon.c like we do in the @bazel_tools//src/conditions:darwin_arm64 condition above, and set -DBLAKE3_USE_NEON=1? Same for windows arm64 @meteorcloudy.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah that works, I can make the change for windows here as well, but I'll wait for @meteorcloudy comments.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, /cc @tylerwilliams who made the blake3 contribution in #18682

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tyler gave me the tip. I think we should do the Windows path as well.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah this change looks good to me too

"@bazel_tools//src/conditions:windows_x64": [],
"@bazel_tools//src/conditions:windows_arm64": [
"-DBLAKE3_USE_NEON=0",
Expand Down