Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix OOM in describeNestedSetFingerprint #18668

Closed
wants to merge 1 commit into from
Closed

Fix OOM in describeNestedSetFingerprint #18668

wants to merge 1 commit into from

Conversation

fmeum
Copy link
Collaborator

@fmeum fmeum commented Jun 14, 2023 •
edited
Loading

describedNestedSetFingerprint appended a StringBuilder to itself in a loop instead of the actual item from the nested set, resulting in OOMs in Runfiles#describeKey and RepoMappingManifestAction#describeKey.

Work towards #18666

@fmeum
Fix OOM in Runfiles#describeKey
010fafc 
`describedNestedSetFingerprint` appended a `StringBuilder` to itself in a loop instead of the actual item from the nested set.
@fmeum fmeum requested a review from lberki June 14, 2023 07:15
@github-actions github-actions bot added the awaiting-review PR is awaiting review from an assigned reviewer label Jun 14, 2023
@fmeum
Copy link
Collaborator Author

fmeum commented Jun 14, 2023

@bazel-io flag

@bazel-io bazel-io added the potential release blocker Flagged by community members using "@bazel-io flag". Should be added to a release blocker milestone label Jun 14, 2023
@fmeum fmeum changed the title Fix OOM in Runfiles#describeKey Fix OOM in describeNestedSetFingerprint Jun 14, 2023
@fmeum
Copy link
Collaborator Author

fmeum commented Jun 14, 2023

CC @Wyverald

@fmeum fmeum mentioned this pull request Jun 14, 2023
Closed
lberki
lberki approved these changes Jun 14, 2023
View reviewed changes
Copy link
Contributor

@lberki lberki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix! This is somewhat embarrassing.

@lberki lberki added awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally and removed awaiting-review PR is awaiting review from an assigned reviewer labels Jun 14, 2023
@iancha1992
Copy link
Member

@bazel-io fork 6.3.0

@bazel-io bazel-io removed the potential release blocker Flagged by community members using "@bazel-io flag". Should be added to a release blocker milestone label Jun 14, 2023
@bazel-io bazel-io mentioned this pull request Jun 14, 2023
Closed
@iancha1992 iancha1992 added team-ExternalDeps External dependency handling, remote repositiories, WORKSPACE file. and removed awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally labels Jun 14, 2023
iancha1992 pushed a commit to iancha1992/bazel that referenced this pull request Jun 14, 2023
@fmeum @iancha1992
Fix OOM in describeNestedSetFingerprint
914d94b 
`describedNestedSetFingerprint` appended a `StringBuilder` to itself in a loop instead of the actual item from the nested set, resulting in OOMs in `Runfiles#describeKey` and `RepoMappingManifestAction#describeKey`.

Work towards bazelbuild#18666

Closes bazelbuild#18668.

PiperOrigin-RevId: 540270874
Change-Id: Id408ab4c2438bea264b586f8ae5567dc41260242
@iancha1992 iancha1992 mentioned this pull request Jun 14, 2023
Closed
traversaro pushed a commit to traversaro/bazel that referenced this pull request Jun 24, 2023
@fmeum @traversaro
Fix OOM in describeNestedSetFingerprint
5272ea6 
`describedNestedSetFingerprint` appended a `StringBuilder` to itself in a loop instead of the actual item from the nested set, resulting in OOMs in `Runfiles#describeKey` and `RepoMappingManifestAction#describeKey`.

Work towards bazelbuild#18666

Closes bazelbuild#18668.

PiperOrigin-RevId: 540270874
Change-Id: Id408ab4c2438bea264b586f8ae5567dc41260242
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lberki lberki lberki approved these changes

Assignees
No one assigned
Labels
team-ExternalDeps External dependency handling, remote repositiories, WORKSPACE file.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@fmeum @iancha1992 @lberki @bazel-io