-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix message generation of ActionExecutionException
#18243
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
awaiting-review
PR is awaiting review from an assigned reviewer
label
Apr 27, 2023
@meteorcloudy Modifying exception messages may have been naive. I noticed that this ended up duplicating messages in other places, e.g. the one emitted by the |
fmeum
changed the title
Fix message generation of
Fix message generation of Apr 27, 2023
ActionExecutionException
"ActionExecutionException
@bazel-io flag |
bazel-io
added
the
potential release blocker
Flagged by community members using "@bazel-io flag". Should be added to a release blocker milestone
label
Apr 27, 2023
This fixes an issue introduced by commit f95b80d, which resulted in certain exception message being printed twice.
fmeum
force-pushed
the
fix-action-execution-exception
branch
from
April 27, 2023 21:00
d48f055
to
9477edf
Compare
@bazel-io fork 6.2.0 |
bazel-io
removed
the
potential release blocker
Flagged by community members using "@bazel-io flag". Should be added to a release blocker milestone
label
Apr 27, 2023
meteorcloudy
approved these changes
Apr 28, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
meteorcloudy
added
awaiting-PR-merge
PR has been approved by a reviewer and is ready to be merge internally
and removed
awaiting-review
PR is awaiting review from an assigned reviewer
labels
Apr 28, 2023
Pavank1992
removed
the
awaiting-PR-merge
PR has been approved by a reviewer and is ready to be merge internally
label
Apr 28, 2023
Wyverald
pushed a commit
that referenced
this pull request
Apr 28, 2023
This fixes an issue introduced by commit f95b80d, which resulted in certain exception message being printed twice. Closes #18243. PiperOrigin-RevId: 527848438 Change-Id: Ic0f7a4a0e3bdf07c1c520647dbb4b41d29e05648 Co-authored-by: Fabian Meumertzheim <[email protected]>
fweikert
pushed a commit
to fweikert/bazel
that referenced
this pull request
May 25, 2023
This fixes an issue introduced by commit f95b80d, which resulted in certain exception message being printed twice. Closes bazelbuild#18243. PiperOrigin-RevId: 527848438 Change-Id: Ic0f7a4a0e3bdf07c1c520647dbb4b41d29e05648
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an issue introduced by commit f95b80d, which resulted in certain exception message being printed twice.