-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Android Rules Starlark Migration #5354
Comments
Why is moving android tools out of the binary a blocking issue? |
@aj-michael renamed it to "related". It doesn't block the rewrite, but will be good to also migrate our tools out to tools_android (which @ahumesky is making) |
/tag @bazelbuild/android |
It would be great to have an update on the progress of the rules, considering that it's been 6 months since rules_android was created. @10-10-11 / @ahumesky? |
The rules_android roadmap is live: https://github.com/bazelbuild/rules_android/blob/master/ROADMAP.md |
Just want to throw in a +1 that the Lyft migration is also waiting on these and the kotlin rules. |
Posted PR that updates Android tutorial on the website to use rules_android: #9220 |
Hey folks, During BazelCon 2019, it was said that the starlark Android rules where at feature parity with the Java, in-Bazel ones. It was also said they were already used inside Google and that open source was going to be soon-ish. Would it be possible to have an official statement as to what the roadmap is? This also means that legacy Android rules won't probably much development, and issues such as #11497 don't have any clear way on how to approach them. Thanks you |
Although we don't have a concrete timeline, this is being actively worked on this quarter and next. The soonest we can publish something that works in a minimal way is probably middle of Q1 2021. |
Hi all, These updates contain a significant amount of the Starlark code for the Android toolchains, resource processing, and the android_library rule. It should be possible to build an Android app using the Starlark version of android_library, and the native (i.e. Java) version of android_binary (the Starlark version of android_binary is still just a simple wrapper around the native version). See the readme for requirements. Some of the next steps are to publish the Starlark version of aar_import, and to enable rules_jvm_external to generate dependencies using that Starlark version. After that, there is still a fair bit of work to be done to finish and publish the Starlark version of android_binary. We might also publish some intermediate steps (e.g. an android_binary that delegates functionality to helper rules written in Starlark, all wrapped in an android_binary macro. then over time the helper functions do more and more and the native version goes away). |
see bazelbuild/bazel#5354 pinned_coursier_fetch was missed in original pr bazel-contrib#526
#729) see bazelbuild/bazel#5354 pinned_coursier_fetch was missed in original pr #526
To update on the progress here, the 0.5.1 release of rules_android contains mostly Starlark rules, with notable exception android_sdk_repository, android_local_test, android_sdk, android_ndk_repository, and all Android providers still relying on native rules. rules_android 0.6.0 will contain fully Starlark rules, and the progress of the 0.6.0 release is being tracked in bazelbuild/rules_android#278 The native Android rules have been removed from Bazel 8, and rules_android 0.6.0 will be compatible with Bazel 8 for migration. |
rules_android 0.6.0 has been released: https://github.com/bazelbuild/rules_android/releases/tag/v0.6.0. rules_android 0.6.0 contains fully Starlark Android rules, including Starlark Android Providers and the native Android rules have been removed in Bazel 8. While the Starlark rules are near 1:1 replacements for the native, some differences should be noted:
|
Tracking bug for the Starlark migration of
android_*
rules to https://github.com/bazelbuild/rules_androidcc @bazelbuild/android
Timeline
June 4, 2018
Related issues:
The text was updated successfully, but these errors were encountered: