Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bazel support for full proto on Android (for json and prototxt) #4461

Closed
vmax opened this issue Jan 15, 2018 · 3 comments
Closed

Bazel support for full proto on Android (for json and prototxt) #4461

vmax opened this issue Jan 15, 2018 · 3 comments
Labels
P3 We're not considering working on this, but happy to review a PR. (No assignee) team-Android Issues for Android team type: feature request

Comments

@vmax
Copy link
Contributor

vmax commented Jan 15, 2018

Description of the problem / feature request:

Android: allow java_proto_library as dependency for android_binary

It's impossible to utilize full protobuf library on Android device if build is done by bazel

Feature requests: what underlying problem are you trying to solve with this feature?

I need to include full runtime library together with protobuf-java-util unless there's a way to parse json in lite version of which I don't know.

Bugs: what's the simplest, easiest way to reproduce this bug? Please provide a minimal example if possible.

Create proto file, add it as java_proto_library, add that library as dependency to android_binary

What operating system are you running Bazel on?

macOS 10.13.2

What's the output of bazel info release?

release 0.9.0-homebrew

Any other information, logs, or outputs that you want to share?

To allow this, "java_proto_library" should be added here.

@jin
Copy link
Member

jin commented Jan 16, 2018

cc @ahumesky

@codesuki
Copy link

codesuki commented Mar 6, 2018

@jin Hi is there any progress on this?

We definitely want to have this, too.
According to this issue protobuf-java will scrap lite support.
protocolbuffers/protobuf#4314

Also we are using any which doesn't seem to work with lite.

@oferb
Copy link

oferb commented Apr 2, 2018

See internal draft cl/189732367
Thanks!

@vmax vmax changed the title Android: allow java_proto_library as dependency for android_binary Bazel support for full proto on Android (for json and prototxt) Apr 2, 2018
@jin jin added team-Android Issues for Android team and removed category: rules > android labels Aug 11, 2018
@jin jin added P2 We'll consider working on this in future. (Assignee optional) P3 We're not considering working on this, but happy to review a PR. (No assignee) and removed P2 We'll consider working on this in future. (Assignee optional) labels Dec 21, 2018
@vmax vmax closed this as completed Sep 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P3 We're not considering working on this, but happy to review a PR. (No assignee) team-Android Issues for Android team type: feature request
Projects
None yet
Development

No branches or pull requests

4 participants