Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom RBE timeout for non-test actions #21142

Open
rjobredeaux3 opened this issue Jan 30, 2024 · 0 comments
Open

Custom RBE timeout for non-test actions #21142

rjobredeaux3 opened this issue Jan 30, 2024 · 0 comments
Assignees
Labels
P2 We'll consider working on this in future. (Assignee optional) team-Remote-Exec Issues and PRs for the Execution (Remote) team type: feature request

Comments

@rjobredeaux3
Copy link
Contributor

rjobredeaux3 commented Jan 30, 2024

Description of the feature request:

RBE action timeouts for test actions can be increased using the --test_timeout flag, otherwise the default timeout for RBE actions is one hour.

Bazel can already request a different timeout from RBE (read from execution info here, into SpawExecutionContext here, and into the remote action builder here), but there is no API to do so for non-test actions. My dirty fix at the moment is this + setting a timeout in the execution_requirements of the ctx.actions.run call. It works, though I suspect it would break anyone using "timeout" as a tag in their rule (this could be worked around by maintaining 2 separate lists for tags specified in target definitions vs execution_requirements specified from a ctx.actions.run call).

More generally it seems the list of exec_info keys that we let users specify is intentionally short, so filing this as a feature request in case my approach has unintended consequences I haven't thought of.

Which category does this issue belong to?

Remote Execution

What underlying problem are you trying to solve with this feature?

No response

Which operating system are you running Bazel on?

No response

What is the output of bazel info release?

No response

If bazel info release returns development version or (@non-git), tell us how you built Bazel.

No response

What's the output of git remote get-url origin; git rev-parse HEAD ?

No response

Have you found anything relevant by searching the web?

#12349 would likely be solved by this.

Any other information, logs, or outputs that you want to share?

No response

@tjgq tjgq added the team-Remote-Exec Issues and PRs for the Execution (Remote) team label Jan 30, 2024
@oquenchil oquenchil added P2 We'll consider working on this in future. (Assignee optional) and removed untriaged labels Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P2 We'll consider working on this in future. (Assignee optional) team-Remote-Exec Issues and PRs for the Execution (Remote) team type: feature request
Projects
None yet
Development

No branches or pull requests

7 participants