Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[6.4.0] Merge rule and aspect validation output groups #19742

Closed
bazel-io opened this issue Oct 5, 2023 · 2 comments
Closed

[6.4.0] Merge rule and aspect validation output groups #19742

bazel-io opened this issue Oct 5, 2023 · 2 comments
Milestone
6.4.0 release blo...

Comments

@bazel-io
Copy link
Member

bazel-io commented Oct 5, 2023

Forked from #19630
@bazel-io bazel-io added this to the 6.4.0 release blockers milestone Oct 5, 2023
@bazel-io
Copy link
Member Author

bazel-io commented Oct 5, 2023

Cherry-pick was attempted, but there may be merge conflict(s). Please resolve manually.
cc: @bazelbuild/triage

fmeum added a commit to fmeum/bazel that referenced this issue Oct 6, 2023
@fmeum
Merge rule and aspect validation output groups
e3c27b6 
By merging the special `_validation` output groups across a rule and its attached aspects, aspects and rules can simultaneously use validation actions.

Fixes bazelbuild#19624

Closes bazelbuild#19630.

PiperOrigin-RevId: 571084964
Change-Id: I3135ce1f9e61124e96a3b7d8e0ea0c3a3cdf526d

Fixes bazelbuild#19742
@fmeum fmeum mentioned this issue Oct 6, 2023
Merged
@iancha1992
Copy link
Member

Cherry-picked in #19745 by @fmeum

iancha1992 pushed a commit that referenced this issue Oct 6, 2023
@fmeum
Merge rule and aspect validation output groups (#19745)
ddc3e52 
By merging the special `_validation` output groups across a rule and its
attached aspects, aspects and rules can simultaneously use validation
actions.

Fixes #19624

Closes #19630.

PiperOrigin-RevId: 571084964
Change-Id: I3135ce1f9e61124e96a3b7d8e0ea0c3a3cdf526d

Fixes #19742
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
6.4.0 release blockers
Development

No branches or pull requests
2 participants
@bazel-io @iancha1992