Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tried to set properties for non-existent exec group 'cpp_link'. #13438

Closed
tgerdes-cohesity opened this issue May 6, 2021 · 4 comments
Closed
Labels
P3 We're not considering working on this, but happy to review a PR. (No assignee) stale Issues or PRs that are stale (no activity for 30 days) team-Rules-CPP Issues for C++ rules type: bug

Comments

@tgerdes-cohesity
Copy link

Description of the problem / feature request:

Attempting to set exec_properties for the group cpp_link for cc_binary, cc_library, and cc_test rules does not appear to work. The docs at https://docs.bazel.build/versions/master/exec-groups.html#execution-groups-for-native-rules indicate that this group should be defined by native rules.

Bugs: what's the simplest, easiest way to reproduce this bug? Please provide a minimal example if possible.

cc_binary(
    name = "my_binary",
    srcs = ["my_binary.cc"],
    exec_properties = {
        "cpp_link.resource": "value"
    },
)
$  bazel build --experimental_exec_groups=true //:my_binary
ERROR: Analysis of target '//:my_binary' failed; build aborted: Tried to set exec property 'resource' for non-existent exec group 'cpp_link'.
INFO: Elapsed time: 0.227s
INFO: 0 processes.
FAILED: Build did NOT complete successfully (0 packages loaded, 0 targets configured)

What operating system are you running Bazel on?

Ubuntu 18.04.

What's the output of bazel info release?

$ bazel info release
release 4.0.0

Also tried with a recent build on master using commit f6cce24 , built with bazel build //src:bazel

What's the output of git remote get-url origin ; git rev-parse master ; git rev-parse HEAD ?

$ git remote get-url origin ; git rev-parse master ; git rev-parse HEAD
https://github.com/bazelbuild/bazel
f6cce242420cad432797e0e2501475e821553af7
f6cce242420cad432797e0e2501475e821553af7

Have you found anything relevant by searching the web?

Not specific to the group cpp_link, but there's some discussion of the implementation of the group test on #10799 which I only got to work on master, not version 4.0.0

@sventiffe sventiffe added the team-Rules-CPP Issues for C++ rules label May 7, 2021
@quval
Copy link
Contributor

quval commented May 7, 2021

Looks like this is because the CcLinkingRule, which the cpp_link execution group is defined on, isn't an ancestor of the cc_binary rule (or any cc rule, actually). Should CppRuleClasses.CcLinkingRule.class be an ancestor of CcBaseRule?

@oquenchil oquenchil added P3 We're not considering working on this, but happy to review a PR. (No assignee) type: bug labels May 31, 2021
@vmrob
Copy link

vmrob commented Apr 30, 2022

Any updates on this issue? It does appear that the features described the in docs can't be used because the execution group is effectively nonexistent.

In my particular use case, I was hoping I could run our link steps on larger remote workers as they typically require more resources than compile steps. To do this, I was hoping to leverage the cpp_link execution group to set an execution property for all cpp_link actions.

@github-actions
Copy link

github-actions bot commented Jul 4, 2023

Thank you for contributing to the Bazel repository! This issue has been marked as stale since it has not had any activity in the last 1+ years. It will be closed in the next 90 days unless any other activity occurs or one of the following labels is added: "not stale", "awaiting-bazeler". Please reach out to the triage team (@bazelbuild/triage) if you think this issue is still relevant or you are interested in getting the issue resolved.

@github-actions github-actions bot added the stale Issues or PRs that are stale (no activity for 30 days) label Jul 4, 2023
@github-actions
Copy link

github-actions bot commented Oct 3, 2023

This issue has been automatically closed due to inactivity. If you're still interested in pursuing this, please reach out to the triage team (@bazelbuild/triage). Thanks!

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Oct 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P3 We're not considering working on this, but happy to review a PR. (No assignee) stale Issues or PRs that are stale (no activity for 30 days) team-Rules-CPP Issues for C++ rules type: bug
Projects
None yet
Development

No branches or pull requests

5 participants