Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression: bazel 3.2.0 + glob allow_empty=false + android ndk fails #11518

Closed
iphydf opened this issue May 28, 2020 · 8 comments
Closed

Regression: bazel 3.2.0 + glob allow_empty=false + android ndk fails #11518

iphydf opened this issue May 28, 2020 · 8 comments
Assignees
Labels
P2 We'll consider working on this in future. (Assignee optional) team-Android Issues for Android team type: bug

Comments

@iphydf
Copy link

iphydf commented May 28, 2020

Description of the problem:

As of bazel 3.2.0, passing --incompatible_disallow_empty_glob fails for android builds using NDK r16b:

glob pattern 'ndk/sources/third_party/vulkan/src/build-android/jniLibs/armeabi/libVkLayer_*.so' didn't match anything, but allow_empty is set to False.

There is armeabi-v7a, but no armeabi. This works fine with bazel 3.1.0.

Bugs: what's the simplest, easiest way to reproduce this bug? Please provide a minimal example if possible.

I don't have a minimal repro, but essentially: pass --incompatible_disallow_empty_glob and have an android_ndk_repository.

What operating system are you running Bazel on?

Debian GNU/Linux.

What's the output of bazel info release?

release 3.2.0

Have you found anything relevant by searching the web?

No (I did look, but nothing so far).

Any other information, logs, or outputs that you want to share?

I have not found a workaround for this. I tried --fat_apk_cpu=armeabi-v7a, but that doesn't fix it.

@jin
Copy link
Member

jin commented May 29, 2020

While this is something that should be fixed before enabling the breaking change in #8195, I don't think it's recommended to use an un-flipped --incompatible flag for day to day use. Usually, it's because we haven't provided migration tooling or fixed breaking changes with Bazel's own code (like this issue).

https://docs.bazel.build/versions/master/backward-compatibility.html#at-a-glance

Users should never run their production builds with --experimental_* or --incompatible_* flags.

@jin jin added team-Android Issues for Android team untriaged labels May 29, 2020
@laurentlb
Copy link
Contributor

Who should look at this?
This issue will prevent the flag flip planed for Bazel 4.0.

@laurentlb
Copy link
Contributor

@laurentlb
Copy link
Contributor

ping?

@laurentlb
Copy link
Contributor

@jin @ahumesky @timpeut
Do you know anyone who could look at this?

@ahumesky ahumesky added P2 We'll consider working on this in future. (Assignee optional) type: bug and removed untriaged labels Dec 3, 2020
@ahumesky
Copy link
Contributor

ahumesky commented Dec 3, 2020

#8195 has been moved to 5.0, so we can look at this for next quarter

@limdor
Copy link
Contributor

limdor commented Apr 24, 2022

@ahumesky
Copy link
Contributor

--incompatible_disallow_empty_glob has been rolled out

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P2 We'll consider working on this in future. (Assignee optional) team-Android Issues for Android team type: bug
Projects
None yet
Development

No branches or pull requests

5 participants