From 82fa1cb060d44254f72502a24bb179d7dfc00f94 Mon Sep 17 00:00:00 2001 From: Fabian Meumertzheim Date: Wed, 9 Nov 2022 09:22:21 +0100 Subject: [PATCH] Add and fix comments --- .../java/com/google/devtools/build/lib/analysis/Runfiles.java | 4 +++- .../devtools/build/lib/analysis/SourceManifestAction.java | 3 +-- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/src/main/java/com/google/devtools/build/lib/analysis/Runfiles.java b/src/main/java/com/google/devtools/build/lib/analysis/Runfiles.java index 2153ff144a511c..c8c9a9d350b9a1 100644 --- a/src/main/java/com/google/devtools/build/lib/analysis/Runfiles.java +++ b/src/main/java/com/google/devtools/build/lib/analysis/Runfiles.java @@ -386,7 +386,9 @@ static Map filterListForObscuringSymlinks( * normal source tree entries, or runfile conflicts. May be null, in which case obscuring * symlinks are silently discarded, and conflicts are overwritten. * @param location Location for eventHandler warnings. Ignored if eventHandler is null. - * @param repoMappingManifest repository mapping manifest to add as a root symlink + * @param repoMappingManifest repository mapping manifest to add as a root symlink. This manifest + * has to be added automatically for every executable and is thus not + * part of the Runfiles advertised by a configured target. * @return Map path fragment to artifact, of normal source tree entries * and elements that live outside the source tree. Null values represent empty input files. */ diff --git a/src/main/java/com/google/devtools/build/lib/analysis/SourceManifestAction.java b/src/main/java/com/google/devtools/build/lib/analysis/SourceManifestAction.java index d455777d154b2f..99b350002f41a0 100644 --- a/src/main/java/com/google/devtools/build/lib/analysis/SourceManifestAction.java +++ b/src/main/java/com/google/devtools/build/lib/analysis/SourceManifestAction.java @@ -118,8 +118,7 @@ void writeEntry( @VisibleForTesting SourceManifestAction( ManifestWriter manifestWriter, ActionOwner owner, Artifact primaryOutput, Runfiles runfiles) { - this(manifestWriter, owner, primaryOutput, runfiles, /*remotableSourceManifestActions=*/ null, - false); + this(manifestWriter, owner, primaryOutput, runfiles, null, false); } /**