Skip to content

Commit

Permalink
Remove --nobuild_runfile_links from the expansion of --remote_downloa…
Browse files Browse the repository at this point in the history
…d_minimal.

This is arguably not a "build without the bytes" feature; runfile symlink trees are always local (in-process) outputs and never produced remotely. Omitting the flag from the expansion avoids discarding most of the analysis phase when flipping between --remote_download_toplevel and --remote_download_minimal.

It remains possible to disable the creation of runfile symlink trees by manually setting --nobuild_runfile_links.

See also #18580.

RELNOTES: --remote_download_minimal no longer implies --nobuild_runfile_links.
PiperOrigin-RevId: 561655765
Change-Id: I1ec0ca3e493bccad0feb666987fef04d9c528b12
  • Loading branch information
tjgq authored and copybara-github committed Aug 31, 2023
1 parent 084a876 commit 24ba4fa
Showing 1 changed file with 5 additions and 6 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -475,14 +475,13 @@ public RemoteOutputsStrategyConverter() {
name = "remote_download_minimal",
oldName = "experimental_remote_download_minimal",
defaultValue = "null",
expansion = {"--nobuild_runfile_links", "--remote_download_outputs=minimal"},
expansion = {"--remote_download_outputs=minimal"},
category = "remote",
documentationCategory = OptionDocumentationCategory.OUTPUT_PARAMETERS,
effectTags = {OptionEffectTag.AFFECTS_OUTPUTS},
help =
"Does not download any remote build outputs to the local machine. This flag is a shortcut"
+ " for flags: --nobuild_runfile_links and"
+ " --remote_download_outputs=minimal.")
"Does not download any remote build outputs to the local machine. This flag is an alias"
+ " for --remote_download_outputs=minimal.")
public Void remoteOutputsMinimal;

@Option(
Expand All @@ -495,7 +494,7 @@ public RemoteOutputsStrategyConverter() {
effectTags = {OptionEffectTag.AFFECTS_OUTPUTS},
help =
"Only downloads remote outputs of top level targets to the local machine. This flag is an"
+ " alias for flag --remote_download_outputs=toplevel.")
+ " alias for --remote_download_outputs=toplevel.")
public Void remoteOutputsToplevel;

@Option(
Expand All @@ -506,7 +505,7 @@ public RemoteOutputsStrategyConverter() {
documentationCategory = OptionDocumentationCategory.OUTPUT_PARAMETERS,
effectTags = {OptionEffectTag.AFFECTS_OUTPUTS},
help =
"Downloads all remote outputs to the local machine. This flag is an alias for flag"
"Downloads all remote outputs to the local machine. This flag is an alias for"
+ " --remote_download_outputs=all.")
public Void remoteOutputsAll;

Expand Down

0 comments on commit 24ba4fa

Please sign in to comment.