-
Notifications
You must be signed in to change notification settings - Fork 4.1k
/
Copy pathstarlark_configurations_test.sh
executable file
·1091 lines (852 loc) · 29.2 KB
/
starlark_configurations_test.sh
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
817
818
819
820
821
822
823
824
825
826
827
828
829
830
831
832
833
834
835
836
837
838
839
840
841
842
843
844
845
846
847
848
849
850
851
852
853
854
855
856
857
858
859
860
861
862
863
864
865
866
867
868
869
870
871
872
873
874
875
876
877
878
879
880
881
882
883
884
885
886
887
888
889
890
891
892
893
894
895
896
897
898
899
900
901
902
903
904
905
906
907
908
909
910
911
912
913
914
915
916
917
918
919
920
921
922
923
924
925
926
927
928
929
930
931
932
933
934
935
936
937
938
939
940
941
942
943
944
945
946
947
948
949
950
951
952
953
954
955
956
957
958
959
960
961
962
963
964
965
966
967
968
969
970
971
972
973
974
975
976
977
978
979
980
981
982
983
984
985
986
987
988
989
990
991
992
993
994
995
996
997
998
999
1000
#!/bin/bash
#
# Copyright 2018 The Bazel Authors. All rights reserved.
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.
#
# starlark_configuration_test.sh: integration tests for starlark build configurations
# --- begin runfiles.bash initialization ---
# Copy-pasted from Bazel's Bash runfiles library (tools/bash/runfiles/runfiles.bash).
set -euo pipefail
if [[ ! -d "${RUNFILES_DIR:-/dev/null}" && ! -f "${RUNFILES_MANIFEST_FILE:-/dev/null}" ]]; then
if [[ -f "$0.runfiles_manifest" ]]; then
export RUNFILES_MANIFEST_FILE="$0.runfiles_manifest"
elif [[ -f "$0.runfiles/MANIFEST" ]]; then
export RUNFILES_MANIFEST_FILE="$0.runfiles/MANIFEST"
elif [[ -f "$0.runfiles/bazel_tools/tools/bash/runfiles/runfiles.bash" ]]; then
export RUNFILES_DIR="$0.runfiles"
fi
fi
if [[ -f "${RUNFILES_DIR:-/dev/null}/bazel_tools/tools/bash/runfiles/runfiles.bash" ]]; then
source "${RUNFILES_DIR}/bazel_tools/tools/bash/runfiles/runfiles.bash"
elif [[ -f "${RUNFILES_MANIFEST_FILE:-/dev/null}" ]]; then
source "$(grep -m1 "^bazel_tools/tools/bash/runfiles/runfiles.bash " \
"$RUNFILES_MANIFEST_FILE" | cut -d ' ' -f 2-)"
else
echo >&2 "ERROR: cannot find @bazel_tools//tools/bash/runfiles:runfiles.bash"
exit 1
fi
# --- end runfiles.bash initialization ---
source "$(rlocation "io_bazel/src/test/shell/integration_test_setup.sh")" \
|| { echo "integration_test_setup.sh not found!" >&2; exit 1; }
case "$(uname -s | tr [:upper:] [:lower:])" in
msys*|mingw*|cygwin*)
declare -r is_windows=true
;;
*)
declare -r is_windows=false
;;
esac
function set_up() {
write_default_bazelrc
add_to_bazelrc "build --package_path=%workspace%"
}
#### HELPER FXNS #######################################################
function write_build_setting_bzl() {
cat > $pkg/build_setting.bzl <<EOF
BuildSettingInfo = provider(fields = ['name', 'value'])
def _build_setting_impl(ctx):
return [BuildSettingInfo(name = ctx.attr.name, value = ctx.build_setting_value)]
drink_attribute = rule(
implementation = _build_setting_impl,
build_setting = config.string(flag = True),
)
EOF
cat > $pkg/rules.bzl <<EOF
load("//$pkg:build_setting.bzl", "BuildSettingInfo")
def _impl(ctx):
_type_name = ctx.attr._type[BuildSettingInfo].name
_type_setting = ctx.attr._type[BuildSettingInfo].value
print(_type_name + "=" + str(_type_setting))
_temp_name = ctx.attr._temp[BuildSettingInfo].name
_temp_setting = ctx.attr._temp[BuildSettingInfo].value
print(_temp_name + "=" + str(_temp_setting))
print("strict_java_deps=" + ctx.fragments.java.strict_java_deps)
drink = rule(
implementation = _impl,
attrs = {
"_type":attr.label(default = Label("//$pkg:type")),
"_temp":attr.label(default = Label("//$pkg:temp")),
},
fragments = ["java"],
)
EOF
cat > $pkg/BUILD <<EOF
load("//$pkg:build_setting.bzl", "drink_attribute")
load("//$pkg:rules.bzl", "drink")
drink(name = 'my_drink')
drink_attribute(name = 'type', build_setting_default = 'unknown')
drink_attribute(name = 'temp', build_setting_default = 'unknown')
EOF
}
#### TESTS #############################################################
function test_default_flag() {
local -r pkg=$FUNCNAME
mkdir -p $pkg
write_build_setting_bzl
bazel build //$pkg:my_drink > output 2>"$TEST_log" || fail "Expected success"
expect_log "type=unknown"
}
function test_set_flag() {
local -r pkg=$FUNCNAME
mkdir -p $pkg
write_build_setting_bzl
bazel build //$pkg:my_drink --//$pkg:type="coffee" \
> output 2>"$TEST_log" || fail "Expected success"
expect_log "type=coffee"
}
function test_starlark_and_native_flag() {
local -r pkg=$FUNCNAME
mkdir -p $pkg
write_build_setting_bzl
bazel build //$pkg:my_drink --//$pkg:type=coffee --strict_java_deps=off \
> output 2>"$TEST_log" \
|| fail "Expected success"
expect_log "type=coffee"
expect_log "strict_java_deps=off"
}
function test_dont_parse_flags_after_dash_dash() {
local -r pkg=$FUNCNAME
mkdir -p $pkg
write_build_setting_bzl
bazel build //$pkg:my_drink --//$pkg:type=coffee \
-- --//$pkg:temp=iced > output 2>"$TEST_log" \
&& fail "Expected failure"
expect_log "invalid package name '-//test_dont_parse_flags_after_dash_dash'"
}
function test_multiple_starlark_flags() {
local -r pkg=$FUNCNAME
mkdir -p $pkg
write_build_setting_bzl
bazel build //$pkg:my_drink --//$pkg:type="coffee" --//$pkg:temp="iced" \
> output 2>"$TEST_log" || fail "Expected success"
expect_log "type=coffee"
expect_log "temp=iced"
bazel clean 2>"$TEST_log" || fail "Clean failed"
# Ensure that order doesn't matter.
bazel build //$pkg:my_drink --//$pkg:temp="iced" --//$pkg:type="coffee" \
> output 2>"$TEST_log" || fail "Expected success"
expect_log "type=coffee"
expect_log "temp=iced"
}
function test_flag_default_change() {
local -r pkg=$FUNCNAME
mkdir -p $pkg
write_build_setting_bzl
bazel build //$pkg:my_drink > output 2>"$TEST_log" || fail "Expected success"
expect_log "type=unknown"
cat > $pkg/BUILD <<EOF
load("//$pkg:build_setting.bzl", "drink_attribute")
load("//$pkg:rules.bzl", "drink")
drink(name = 'my_drink')
drink_attribute(name = 'type', build_setting_default = 'cowabunga')
drink_attribute(name = 'temp', build_setting_default = 'cowabunga')
EOF
bazel build //$pkg:my_drink > output 2>"$TEST_log" || fail "Expected success"
expect_log "type=cowabunga"
}
# Regression tests for b/134580627
# Make sure package incrementality works during options parsing
function test_incremental_delete_build_setting() {
local -r pkg=$FUNCNAME
mkdir -p $pkg
cat > $pkg/rules.bzl <<EOF
def _impl(ctx):
return []
my_flag = rule(
implementation = _impl,
build_setting = config.string(flag = True)
)
simple_rule = rule(implementation = _impl)
EOF
cat > $pkg/BUILD <<EOF
load("//$pkg:rules.bzl", "my_flag", "simple_rule")
my_flag(name = "my_flag", build_setting_default = "default")
simple_rule(name = "simple_rule")
EOF
bazel build //$pkg:simple_rule --//$pkg:my_flag=cowabunga \
> output 2>"$TEST_log" \
|| fail "Expected success"
cat > $pkg/BUILD <<EOF
load("//$pkg:rules.bzl", "simple_rule")
simple_rule(name = "simple_rule")
EOF
bazel build //$pkg:simple_rule --//$pkg:my_flag=cowabunga \
> output 2>"$TEST_log" \
&& fail "Expected failure" || true
expect_log "no such target '//$pkg:my_flag'"
}
#############################
function test_incremental_delete_build_setting_in_different_package() {
local -r pkg=$FUNCNAME
mkdir -p $pkg
cat > $pkg/rules.bzl <<EOF
def _impl(ctx):
return []
my_flag = rule(
implementation = _impl,
build_setting = config.string(flag = True)
)
simple_rule = rule(implementation = _impl)
EOF
cat > $pkg/BUILD <<EOF
load("//$pkg:rules.bzl", "my_flag")
my_flag(name = "my_flag", build_setting_default = "default")
EOF
mkdir -p pkg2
cat > pkg2/BUILD <<EOF
load("//$pkg:rules.bzl", "simple_rule")
simple_rule(name = "simple_rule")
EOF
bazel build //pkg2:simple_rule --//$pkg:my_flag=cowabunga \
> output 2>"$TEST_log" || fail "Expected success"
cat > $pkg/BUILD <<EOF
EOF
bazel build //pkg2:simple_rule --//$pkg:my_flag=cowabunga \
> output 2>"$TEST_log" && fail "Expected failure" || true
expect_log "no such target '//$pkg:my_flag'"
}
#############################
function test_incremental_add_build_setting() {
local -r pkg=$FUNCNAME
mkdir -p $pkg
cat > $pkg/rules.bzl <<EOF
def _impl(ctx):
return []
my_flag = rule(
implementation = _impl,
build_setting = config.string(flag = True)
)
simple_rule = rule(implementation = _impl)
EOF
cat > $pkg/BUILD <<EOF
load("//$pkg:rules.bzl", "simple_rule")
simple_rule(name = "simple_rule")
EOF
bazel build //$pkg:simple_rule \
> output 2>"$TEST_log" || fail "Expected success"
cat > $pkg/BUILD <<EOF
load("//$pkg:rules.bzl", "my_flag", "simple_rule")
my_flag(name = "my_flag", build_setting_default = "default")
simple_rule(name = "simple_rule")
EOF
bazel build //$pkg:simple_rule --//$pkg:my_flag=cowabunga \
> output 2>"$TEST_log" || fail "Expected success"
}
function test_incremental_change_build_setting() {
local -r pkg=$FUNCNAME
mkdir -p $pkg
cat > $pkg/rules.bzl <<EOF
MyProvider = provider(fields = ["value"])
def _flag_impl(ctx):
return MyProvider(value = ctx.build_setting_value)
my_flag = rule(
implementation = _flag_impl,
build_setting = config.string(flag = True)
)
def _rule_impl(ctx):
print("flag = " + ctx.attr.flag[MyProvider].value)
simple_rule = rule(
implementation = _rule_impl,
attrs = {"flag" : attr.label()}
)
EOF
cat > $pkg/BUILD <<EOF
load("//$pkg:rules.bzl", "my_flag", "simple_rule")
my_flag(name = "my_flag", build_setting_default = "default")
simple_rule(name = "simple_rule", flag = ":my_flag")
EOF
bazel build //$pkg:simple_rule --//$pkg:my_flag=yabadabadoo \
> output 2>"$TEST_log" || fail "Expected success"
expect_log "flag = yabadabadoo"
# update the flag to return a different value
cat > $pkg/rules.bzl <<EOF
MyProvider = provider(fields = ["value"])
def _flag_impl(ctx):
return MyProvider(value = "scoobydoobydoo")
my_flag = rule(
implementation = _flag_impl,
build_setting = config.string(flag = True)
)
def _rule_impl(ctx):
print("flag = " + ctx.attr.flag[MyProvider].value)
simple_rule = rule(
implementation = _rule_impl,
attrs = {"flag" : attr.label()}
)
EOF
bazel build //$pkg:simple_rule --//$pkg:my_flag=yabadabadoo \
> output 2>"$TEST_log" || fail "Expected success"
expect_log "flag = scoobydoobydoo"
}
# Test that label-typed build setting has access to providers of the
# target it points to.
function test_label_flag() {
local -r pkg=$FUNCNAME
mkdir -p $pkg
cat > $pkg/BUILD <<EOF
load("//$pkg:rules.bzl", "my_rule", "simple_rule")
my_rule(name = "my_rule")
simple_rule(name = "default", value = "default_val")
simple_rule(name = "command_line", value = "command_line_val")
label_flag(
name = "my_label_build_setting",
build_setting_default = ":default"
)
EOF
cat > $pkg/rules.bzl <<EOF
def _impl(ctx):
_setting = ctx.attr._label_flag[SimpleRuleInfo].value
print("value=" + _setting)
my_rule = rule(
implementation = _impl,
attrs = {
"_label_flag": attr.label(default = Label("//$pkg:my_label_build_setting")),
},
)
SimpleRuleInfo = provider(fields = ['value'])
def _simple_rule_impl(ctx):
return [SimpleRuleInfo(value = ctx.attr.value)]
simple_rule = rule(
implementation = _simple_rule_impl,
attrs = {
"value":attr.string(),
},
)
EOF
bazel build //$pkg:my_rule > output 2>"$TEST_log" || fail "Expected success"
expect_log "value=default_val"
bazel build //$pkg:my_rule --//$pkg:my_label_build_setting=//$pkg:command_line > output \
2>"$TEST_log" || fail "Expected success"
expect_log "value=command_line_val"
}
function write_label_flag_invalidation_transition() {
local pkg="$1"
local value="$2"
cat > $pkg/transition.bzl <<EOF
def _impl(settings, attr):
# buildifier: disable=unused-variable
_ignore = settings, attr
return {
"//$pkg:my_label_build_setting": "//$pkg:$value",
}
label_flag_transition = transition(
implementation = _impl,
inputs = [],
outputs = ["//$pkg:my_label_build_setting"],
)
EOF
}
# Regression test for https://github.com/bazelbuild/bazel/issues/23097
function test_label_flag_invalidation() {
local -r pkg=$FUNCNAME
mkdir -p $pkg
cat > $pkg/BUILD <<EOF
load("//$pkg:rules.bzl", "my_rule", "simple_rule")
my_rule(name = "my_rule")
simple_rule(name = "default", value = "default_val")
simple_rule(name = "first", value = "first_val")
simple_rule(name = "second", value = "second_val")
label_flag(
name = "my_label_build_setting",
build_setting_default = ":default"
)
EOF
cat > $pkg/rules.bzl <<EOF
load("//$pkg:transition.bzl", "label_flag_transition")
def _impl(ctx):
_setting = ctx.attr._label_flag[SimpleRuleInfo].value
print("value=" + _setting)
my_rule = rule(
implementation = _impl,
cfg = label_flag_transition,
attrs = {
"_label_flag": attr.label(default = Label("//$pkg:my_label_build_setting")),
},
)
SimpleRuleInfo = provider(fields = ['value'])
def _simple_rule_impl(ctx):
return [SimpleRuleInfo(value = ctx.attr.value)]
simple_rule = rule(
implementation = _simple_rule_impl,
attrs = {
"value":attr.string(),
},
)
EOF
# Write the transition to set the flag value to `first`.
write_label_flag_invalidation_transition "$pkg" "first"
bazel build //$pkg:my_rule > output 2>"$TEST_log" || fail "Expected success"
expect_log "value=first_val"
# Now rewrite the transition to change the value to second, and ensure the
# target is re-run.
write_label_flag_invalidation_transition "$pkg" "second"
bazel build //$pkg:my_rule > output 2>"$TEST_log" || fail "Expected success"
expect_log "value=second_val"
expect_not_log "value=first_val"
}
function test_output_same_config_as_generating_target() {
local -r pkg=$FUNCNAME
mkdir -p $pkg
rm -rf tools/allowlists/function_transition_allowlist
mkdir -p tools/allowlists/function_transition_allowlist
cat > tools/allowlists/function_transition_allowlist/BUILD <<EOF
package_group(
name = "function_transition_allowlist",
packages = [
"//...",
],
)
EOF
cat > $pkg/rules.bzl <<EOF
def _rule_class_transition_impl(settings, attr):
return {
"//command_line_option:platform_suffix": "blah"
}
_rule_class_transition = transition(
implementation = _rule_class_transition_impl,
inputs = [],
outputs = [
"//command_line_option:platform_suffix",
],
)
def _rule_class_transition_rule_impl(ctx):
ctx.actions.write(ctx.outputs.artifact, "hello\n")
return [DefaultInfo(files = depset([ctx.outputs.artifact]))]
rule_class_transition_rule = rule(
_rule_class_transition_rule_impl,
cfg = _rule_class_transition,
outputs = {"artifact": "%{name}.output"},
)
EOF
cat > $pkg/BUILD <<EOF
load("//$pkg:rules.bzl", "rule_class_transition_rule")
rule_class_transition_rule(name = "with_rule_class_transition")
EOF
bazel build //$pkg:with_rule_class_transition.output > output 2>"$TEST_log" || fail "Expected success"
bazel cquery "deps(//$pkg:with_rule_class_transition.output, 1)" > output 2>"$TEST_log" || fail "Expected success"
assert_contains "//$pkg:with_rule_class_transition.output " output
assert_contains "//$pkg:with_rule_class_transition " output
# Find the lines of output for the output target and the generating target
OUTPUT=$(grep "//$pkg:with_rule_class_transition.output " output)
TARGET=$(grep "//$pkg:with_rule_class_transition " output)
# Trim to just configuration
OUTPUT_CONFIG=${OUTPUT#* }
TARGET_CONFIG=${TARGET#* }
# Confirm same configuration
assert_equals $OUTPUT_CONFIG $TARGET_CONFIG
}
function test_starlark_flag_change_causes_action_rerun() {
local -r pkg="$FUNCNAME"
mkdir -p "$pkg"
cat > "$pkg/rules.bzl" <<EOF
BuildSettingInfo = provider(fields = ["value"])
def _impl(ctx):
return BuildSettingInfo(value = ctx.build_setting_value)
bool_flag = rule(
implementation = _impl,
build_setting = config.bool(flag = True),
)
EOF
cat > "$pkg/BUILD" <<EOF
load(":rules.bzl", "bool_flag")
bool_flag(
name = "myflag",
build_setting_default = True,
)
config_setting(
name = "myflag_selectable",
flag_values = {":myflag": "True"},
)
genrule(
name = "test_flag",
outs = ["out-flag.txt"],
cmd = "echo Value=" + select({
":myflag_selectable": "True",
"//conditions:default": "False",
}) + " | tee \$@",
)
EOF
bazel shutdown
# Setting --noexperimental_check_output_files is required to reproduce the
# issue: The bug this test covers was caused by starlark flag changes not
# invalidating the analysis cache, resulting in Bazel not re-running the
# genrule action during the third invocation (because it sees the action in
# skyframe as already executed from the first invocation). Bazel will by
# default also invalidate actions by checking all output files for
# modification *unless* an output service is registered (which can -
# correctly - indicate that the output hasn't changed since the last build,
# here between the second and third runs). As we don't have an output service
# available in this test we disable output file checking entirely instead.
bazel build "//$pkg:test_flag" "--//$pkg:myflag=true" \
--noexperimental_check_output_files \
2>>"$TEST_log" || fail "Expected build to succeed"
assert_equals "Value=True" "$(cat bazel-genfiles/$pkg/out-flag.txt)"
bazel build "//$pkg:test_flag" "--//$pkg:myflag=false" \
--noexperimental_check_output_files \
2>>"$TEST_log" || fail "Expected build to succeed"
assert_equals "Value=False" "$(cat bazel-genfiles/$pkg/out-flag.txt)"
bazel build "//$pkg:test_flag" "--//$pkg:myflag=true" \
--noexperimental_check_output_files \
2>>"$TEST_log" || fail "Expected build to succeed"
assert_equals "Value=True" "$(cat bazel-genfiles/$pkg/out-flag.txt)"
}
# Integration test for an invalid output directory from a mnemonic via a
# transition. Integration test required because error is emitted in BuildTool.
# Unit test for dep transition in
# StarlarkRuleTransitionProviderTest#invalidMnemonicFromDepTransition.
function test_invalid_mnemonic_from_transition_top_level() {
mkdir -p tools/allowlists/function_transition_allowlist test
cat > tools/allowlists/function_transition_allowlist/BUILD <<'EOF'
package_group(
name = 'function_transition_allowlist',
packages = [
'//test/...',
],
)
EOF
cat > test/rule.bzl <<'EOF'
def _trans_impl(settings, attr):
return {'//command_line_option:cpu': '//bad:cpu'}
my_transition = transition(implementation = _trans_impl, inputs = [],
outputs = ['//command_line_option:cpu'])
def _impl(ctx):
return []
my_rule = rule(
implementation = _impl,
cfg = my_transition,
)
EOF
cat > test/BUILD <<'EOF'
load('//test:rule.bzl', 'my_rule')
my_rule(name = 'test')
EOF
bazel build //test:test >& "$TEST_log" || exit_code="$?"
assert_equals 1 "$exit_code" || fail "Expected exit code 1"
expect_log "CPU/Platform descriptor '//bad:cpu'"
expect_log "is invalid as part of a path: must not contain /"
}
function test_rc_flag_alias_canonicalizes() {
local -r pkg=$FUNCNAME
mkdir -p $pkg
add_to_bazelrc "build --flag_alias=drink=//$pkg:type"
write_build_setting_bzl
bazel canonicalize-flags -- --drink=coffee \
>& "$TEST_log" || fail "Expected success"
expect_log "--//$pkg:type=coffee"
}
function test_rc_flag_alias_supported_under_common_command() {
local -r pkg=$FUNCNAME
mkdir -p $pkg
add_to_bazelrc "common --flag_alias=drink=//$pkg:type"
write_build_setting_bzl
bazel canonicalize-flags -- --drink=coffee \
>& "$TEST_log" || fail "Expected success"
bazel build //$pkg:my_drink >& "$TEST_log" || fail "Expected success"
}
function test_rc_flag_alias_unsupported_under_test_command() {
local -r pkg=$FUNCNAME
mkdir -p $pkg
add_to_bazelrc "test --flag_alias=drink=//$pkg:type"
write_build_setting_bzl
bazel canonicalize-flags -- --drink=coffee \
>& "$TEST_log" && fail "Expected failure"
expect_log "--flag_alias=drink=//$pkg:type\" disallowed. --flag_alias only "\
"supports these commands: build, common, always"
bazel build //$pkg:my_drink >& "$TEST_log" && fail "Expected failure"
expect_log "--flag_alias=drink=//$pkg:type\" disallowed. --flag_alias only "\
"supports these commands: build, common, always"
# Post-test cleanup_workspace() calls "bazel clean", which would also fail
# unless we reset the bazelrc.
write_default_bazelrc
}
function test_rc_flag_alias_unsupported_under_conditional_build_command() {
local -r pkg=$FUNCNAME
mkdir -p $pkg
add_to_bazelrc "build:foo --flag_alias=drink=//$pkg:type"
write_build_setting_bzl
bazel canonicalize-flags -- --drink=coffee \
>& "$TEST_log" && fail "Expected failure"
expect_log "--flag_alias=drink=//$pkg:type\" disallowed. --flag_alias only "\
"supports these commands: build, common, always"
bazel build //$pkg:my_drink >& "$TEST_log" && fail "Expected failure"
expect_log "--flag_alias=drink=//$pkg:type\" disallowed. --flag_alias only "\
"supports these commands: build, common, always"
# Post-test cleanup_workspace() calls "bazel clean", which would also fail
# unless we reset the bazelrc.
write_default_bazelrc
}
function test_rc_flag_alias_unsupported_with_space_assignment_syntax() {
local -r pkg=$FUNCNAME
mkdir -p $pkg
add_to_bazelrc "test --flag_alias drink=//$pkg:type"
write_build_setting_bzl
bazel canonicalize-flags -- --drink=coffee \
>& "$TEST_log" && fail "Expected failure"
expect_log "--flag_alias\" disallowed. --flag_alias only "\
"supports these commands: build, common, always"
bazel build //$pkg:my_drink >& "$TEST_log" && fail "Expected failure"
expect_log "--flag_alias\" disallowed. --flag_alias only "\
"supports these commands: build, common, always"
# Post-test cleanup_workspace() calls "bazel clean", which would also fail
# unless we reset the bazelrc.
write_default_bazelrc
}
# Regression test for https://github.com/bazelbuild/bazel/issues/13751.
function test_rule_exec_transition_warning() {
local -r pkg=$FUNCNAME
mkdir -p $pkg
cat > "${pkg}/rules.bzl" <<EOF
def _impl(ctx):
pass
demo = rule(
implementation = _impl,
cfg = config.exec(),
)
EOF
cat > "${pkg}/BUILD" <<EOF
load(":rules.bzl", "demo")
demo(name = "demo")
EOF
bazel build //$pkg:demo >& "$TEST_log" && fail "Expected failure"
expect_not_log "crashed due to an internal error"
expect_log '`cfg` must be set to a transition object initialized by the transition() function'
}
function write_attr_list_transition() {
local pkg="${1}"
mkdir -p "${pkg}"
# Define starlark flag rules.
mkdir -p settings
touch settings/BUILD
cat > settings/flag.bzl <<EOF
BuildSettingInfo = provider(fields = ["value"])
def _flag_impl(ctx):
return [BuildSettingInfo(value = ctx.build_setting_value)]
bool_flag = rule(
implementation = _flag_impl,
build_setting = config.bool(flag = True)
)
string_list_flag = rule(
implementation = _flag_impl,
build_setting = config.string_list(),
)
EOF
# Create transition definition
mkdir -p "${pkg}/rule"
touch "${pkg}/rule/BUILD"
cat > "${pkg}/rule/def.bzl" <<EOF
load("//settings:flag.bzl", "BuildSettingInfo")
example_package = "${pkg}"
# Transition that checks a list-typed attribute.
def _transition_impl(settings, attr):
values = getattr(attr, "values")
sorted_values = sorted(values)
print("From transition: values = %s" % str(values))
print("From transition: sorted values = %s" % str(sorted_values))
return {"//%s/flag:transition_output_flag" % example_package: sorted_values}
example_transition = transition(
implementation = _transition_impl,
inputs = [],
outputs = ["//%s/flag:transition_output_flag" % example_package],
)
def _parent_rule_impl(ctx):
attr_values = ctx.attr.values
print("From parent rule attributes: values = %s" % str(attr_values))
parent = rule(
implementation = _parent_rule_impl,
cfg = example_transition,
attrs = {
"values": attr.string_list(),
"child": attr.label(allow_single_file = True),
},
)
def _child_rule_impl(ctx):
flag_values = ctx.attr._transition_output_flag[BuildSettingInfo].value
print("From child rule flag: values = %s" % str(flag_values))
log = ctx.outputs.log
content = "flag: %s" % str(flag_values)
ctx.actions.write(
output = log,
content = content,
)
child = rule(
implementation = _child_rule_impl,
attrs = {
"_transition_output_flag": attr.label(default = "//%s/flag:transition_output_flag" % example_package),
"log": attr.output(),
},
)
EOF
mkdir -p "${pkg}/flag"
# Define the flags that are used.
cat > "${pkg}/flag/BUILD" <<EOF
load("//settings:flag.bzl", "bool_flag", "string_list_flag")
package(
default_visibility = ["//visibility:public"],
)
bool_flag(
name = "select_flag",
build_setting_default = True,
)
string_list_flag(
name = "transition_output_flag",
build_setting_default = [],
)
EOF
}
# Regression test for b/338660045
function test_inspect_attribute_list_direct() {
local -r pkg="${FUNCNAME[0]}"
write_attr_list_transition "${pkg}"
# create rules with transition attached
cat > "${pkg}/BUILD" <<EOF
load(
"//${pkg}/rule:def.bzl",
"parent", "child",
)
config_setting(
name = "select_setting",
flag_values = {"//${pkg}/flag:select_flag": "True"},
)
FRUITS = [
# Deliberately not sorted.
"banana",
"grape",
"apple",
]
ROCKS = [
# Deliberately not sorted.
"marble",
"granite",
"sandstone",
]
child(
name = "child",
log = "child.log",
)
parent(
name = "top_level",
child = ":child",
values = select({
":select_setting": FRUITS,
"//conditions:default": ROCKS,
}),
)
EOF
bazel build "--//${pkg}/flag:select_flag" "//${pkg}:top_level" &> $TEST_log || fail "Build failed"
expect_log 'From parent rule attributes: values = \["banana", "grape", "apple"\]'
expect_log 'From child rule flag: values = \["apple", "banana", "grape"\]'
bazel build "--//${pkg}/flag:select_flag=false" "//${pkg}:top_level" &> $TEST_log || fail "Build failed"
expect_log 'From parent rule attributes: values = \["marble", "granite", "sandstone"\]'
expect_log 'From child rule flag: values = \["granite", "marble", "sandstone"\]'
}
function test_inspect_attribute_list_via_output() {
local -r pkg="${FUNCNAME[0]}"
write_attr_list_transition "${pkg}"
# create rules with transition attached
cat > "${pkg}/BUILD" <<EOF
load(
"//${pkg}/rule:def.bzl",
"parent", "child",
)
config_setting(
name = "select_setting",
flag_values = {"//${pkg}/flag:select_flag": "True"},
)
FRUITS = [
# Deliberately not sorted.
"banana",
"grape",
"apple",
]
ROCKS = [
# Deliberately not sorted.
"marble",
"granite",
"sandstone",
]