Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

oci_push does not pass the runfile correctly to the dependent rule #658

Open
seyoung-song-walmart-com opened this issue Jul 22, 2024 · 2 comments
Labels
can close? We'll close this issue if we don't get a new comment in 30 days. need: information We need more information to identify the bug

Comments

@seyoung-song-walmart-com

Assuming an executable rule X depends on a oci_push rule that depends on a oci_image rule, running the rule X build image using the oci_image but does not push the image using oci_push rule. The problem seems to be oci_push does not pass the push script the next executable rule while oci_image does.

@seyoung-song-walmart-com seyoung-song-walmart-com changed the title oci_push does not pass the runfile to the dependent rule oci_push does not pass the runfile correctly to the dependent rule Jul 23, 2024
@thesayyn
Copy link
Collaborator

I don't understand the problem here.

oci_push does not pass the push script the next executable rule while oci_image does.

I don't follow, oci_image does not have an executable in the DefaultInfo, and i am not sure what you mean by pass the executable.

@thesayyn thesayyn added need: information We need more information to identify the bug can close? We'll close this issue if we don't get a new comment in 30 days. labels Jul 25, 2024
@seyoung-song-walmart-com
Copy link
Author

For example, let's assume that there are oci_image target t1, oci_push target t2 that is pointing t1 as dependency, and custom rule target t3 that has t2 in the deps.
When I execute "bazel run t3", t1 is executed, t2 is not executed and t3 is executed.
When I execute "bazel run t2", t1 is executed, then t2 is executed.
It means oci_image pass DefaultInfo correctly so that downstream target run executes dependent oci_image target.
However, oci_push does not pass DefaultInfo in the way that the downstream target run does not execute dependent oci_push target.
I hope this example explain the problem of oci_push clearly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
can close? We'll close this issue if we don't get a new comment in 30 days. need: information We need more information to identify the bug
Projects
None yet
Development

No branches or pull requests

2 participants