Clean test run #829
Merged
Clean test run #829
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This test has been failing for a while, and yet we've never noticed, and we don't seem to care. It depends on us exposing the cached files from coursier. Given that this code is stable and unlikely to change (see bazel-contrib#807) this feels like a safe change to make.
cheister
reviewed
Jan 15, 2023
| String uriString = uri.toString(); | ||
| if (uriString.contains("repo1.maven.org") && uriString.contains("guava")) { | ||
| foundGuavaJar = true; | ||
| if (OS.indexOf("mac") >= 0) { |
There was a problem hiding this comment.
Does this test not pass on Mac? Or do we just not need this test anymore?
There was a problem hiding this comment.
It doesn't pass anywhere. Ever since we switched to adding explicit visibilities on targets rather than having it set at the package level (#649), this test hasn't passed anywhere since we're not exporting the files. I've no idea why our CI runs haven't caught this, but it's been that way for a year now.
There was a problem hiding this comment.
Let's delete the feature, then?
There was a problem hiding this comment.
Sure. I can do that.
jin
approved these changes
Jan 18, 2023
private/rules/maven_bom_fragment.bzl
Outdated
| @@ -12,10 +12,22 @@ MavenBomFragmentInfo = provider( | |||
| ) | |||
|
|
|||
| def _maven_bom_fragment_impl(ctx): | |||
| java_info = ctx.attr.artifact[JavaInfo] | |||
|
|
|||
| # Recent Bazel versions | |||
There was a problem hiding this comment.
nit: mention the exact version cutover
shs96c
force-pushed
the
clean-test-run
branch
from
79886e7 to
fd03048
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With these changes,
bazel test //...on macOS runs cleanly, without failures.