diff --git a/.bazelci/presubmit.yml b/.bazelci/presubmit.yml index 90a625463d..0bbff25c72 100644 --- a/.bazelci/presubmit.yml +++ b/.bazelci/presubmit.yml @@ -10,8 +10,6 @@ tasks: ubuntu1804_bazel400: platform: ubuntu1804 bazel: 5.4.0 # test minimum supported version of bazel - shell_commands: - - tests/core/cgo/generate_imported_dylib.sh build_targets: - "//..." - "--" @@ -33,8 +31,6 @@ tasks: - "-//tests/runfiles:runfiles_test" ubuntu2004: # enable some unflipped incompatible flags on this platform to ensure we don't regress. - shell_commands: - - tests/core/cgo/generate_imported_dylib.sh build_flags: - "--config=incompatible" test_flags: @@ -49,8 +45,6 @@ tasks: - "//..." debian11_zig_cc: platform: debian11 - shell_commands: - - tests/core/cgo/generate_imported_dylib.sh build_flags: - "--config=incompatible" - "--extra_toolchains=@zig_sdk//toolchain:linux_amd64_gnu.2.31" @@ -92,8 +86,6 @@ tasks: test_targets: - "//..." macos_arm64: - shell_commands: - - tests/core/cgo/generate_imported_dylib.sh build_flags: - "--apple_crosstool_top=@local_config_apple_cc//:toolchain" - "--crosstool_top=@local_config_apple_cc//:toolchain" @@ -111,8 +103,6 @@ tasks: test_targets: - "//..." rbe_ubuntu1604: - shell_commands: - - tests/core/cgo/generate_imported_dylib.sh build_targets: - "//..." - "--" diff --git a/.bazelrc b/.bazelrc index 2c3b408a8f..4848dcb274 100644 --- a/.bazelrc +++ b/.bazelrc @@ -37,6 +37,4 @@ build:incompatible --incompatible_disable_starlark_host_transitions build:incompatible --nolegacy_external_runfiles build:incompatible --incompatible_enable_proto_toolchain_resolution # Also enable all incompatible flags in go_bazel_test by default. -# TODO: Add --incompatible_disallow_empty_glob once -# https://github.com/bazelbuild/bazel-gazelle/pull/1405 has been released. -test:incompatible --test_env=GO_BAZEL_TEST_BAZELFLAGS='--incompatible_load_proto_rules_from_bzl --incompatible_enable_cc_toolchain_resolution --incompatible_config_setting_private_default_visibility --incompatible_enforce_config_setting_visibility --incompatible_disable_starlark_host_transitions --nolegacy_external_runfiles --incompatible_enable_proto_toolchain_resolution' +test:incompatible --test_env=GO_BAZEL_TEST_BAZELFLAGS='--incompatible_disallow_empty_glob --incompatible_load_proto_rules_from_bzl --incompatible_enable_cc_toolchain_resolution --incompatible_config_setting_private_default_visibility --incompatible_enforce_config_setting_visibility --incompatible_disable_starlark_host_transitions --nolegacy_external_runfiles --incompatible_enable_proto_toolchain_resolution' diff --git a/WORKSPACE b/WORKSPACE index e44ca0c3e1..df8d17d299 100644 --- a/WORKSPACE +++ b/WORKSPACE @@ -122,10 +122,10 @@ bazel_skylib_workspace() http_archive( name = "bazel_gazelle", - sha256 = "b7387f72efb59f876e4daae42f1d3912d0d45563eac7cb23d1de0b094ab588cf", + sha256 = "b760f7fe75173886007f7c2e616a21241208f3d90e8657dc65d36a771e916b6a", urls = [ - "https://mirror.bazel.build/github.com/bazelbuild/bazel-gazelle/releases/download/v0.34.0/bazel-gazelle-v0.34.0.tar.gz", - "https://github.com/bazelbuild/bazel-gazelle/releases/download/v0.34.0/bazel-gazelle-v0.34.0.tar.gz", + "https://mirror.bazel.build/github.com/bazelbuild/bazel-gazelle/releases/download/v0.39.1/bazel-gazelle-v0.39.1.tar.gz", + "https://github.com/bazelbuild/bazel-gazelle/releases/download/v0.39.1/bazel-gazelle-v0.39.1.tar.gz", ], ) @@ -193,18 +193,6 @@ go_repository( version = "v0.0.0-20221024183307-1bc688fe9f3e", ) -# TODO(sluongng): Gazelle v0.25.0 switched to static dependency resolution which cause -# build files generation in external dependencies to wrongly resolve these repositories. -# We should investigate in Gazelle why this happen and fix it. -# For now, use manual mapping as a workaround. -# -# gazelle:repository go_repository name=org_golang_x_tools importpath=golang.org/x/tools -# gazelle:repository go_repository name=org_golang_x_text importpath=golang.org/x/text -# gazelle:repository go_repository name=org_golang_x_xerrors importpath=golang.org/x/xerrors -# gazelle:repository go_repository name=org_golang_x_net importpath=golang.org/x/net -# gazelle:repository go_repository name=org_golang_x_sys importpath=golang.org/x/sys -# gazelle:repository go_repository name=org_golang_x_crypto importpath=golang.org/x/crypto - load("@io_bazel_rules_go//tests/legacy/test_chdir:remote.bzl", "test_chdir_remote") test_chdir_remote() diff --git a/tests/core/cgo/BUILD.bazel b/tests/core/cgo/BUILD.bazel index 3fcd9875ef..074623b61f 100644 --- a/tests/core/cgo/BUILD.bazel +++ b/tests/core/cgo/BUILD.bazel @@ -99,16 +99,45 @@ go_library( tags = ["manual"], ) + +genrule( + name = "generate_imported_dylib_linux", + srcs = ["imported.c"], + tools = ["generate_imported_dylib.sh"], + outs = [ + "libimported.so", + "libversioned.so.2", + ], + cmd = "$(location generate_imported_dylib.sh) $(location imported.c) $(@D)", + target_compatible_with = ["@platforms//os:linux"], +) + +genrule( + name = "generate_imported_dylib_darwin", + srcs = ["imported.c"], + tools = ["generate_imported_dylib.sh"], + outs = [ + "libimported.dylib", + "libversioned.2.dylib", + "libversioned.dylib.2", + "libversioned.dylib", + ], + cmd = "$(location generate_imported_dylib.sh) $(location imported.c) $(@D)", + target_compatible_with = ["@platforms//os:macos"], +) + cc_import( name = "darwin_imported_dylib", shared_library = "libimported.dylib", tags = ["manual"], + target_compatible_with = ["@platforms//os:macos"], ) cc_import( name = "linux_imported_dylib", - shared_library = ":libimported.so", + shared_library = "libimported.so", tags = ["manual"], + target_compatible_with = ["@platforms//os:linux"], ) go_test( @@ -187,12 +216,14 @@ cc_import( name = "linux_imported_versioned_dylib", shared_library = "libversioned.so.2", tags = ["manual"], + target_compatible_with = ["@platforms//os:linux"], ) cc_import( name = "darwin_imported_versioned_dylib", shared_library = "libversioned.2.dylib", tags = ["manual"], + target_compatible_with = ["@platforms//os:macos"], ) go_test( @@ -212,7 +243,6 @@ go_library( target_compatible_with = ["@platforms//os:macos"], ) -# //tests/core/cgo:generate_imported_dylib.sh must be run first cc_library( name = "oracle_convention_darwin_dylib", srcs = [ diff --git a/tests/core/cgo/generate_imported_dylib.sh b/tests/core/cgo/generate_imported_dylib.sh index 41227b7737..946f047412 100755 --- a/tests/core/cgo/generate_imported_dylib.sh +++ b/tests/core/cgo/generate_imported_dylib.sh @@ -1,23 +1,25 @@ #!/usr/bin/env bash -set -exo pipefail +set -eo pipefail -cd "$(dirname "$0")" +IMPORTED_C_PATH="$1" +OUTPUT_DIR="$2" case "$(uname -s)" in Linux*) - cc -shared -o libimported.so imported.c - cc -shared -o libversioned.so.2 imported.c + cc -shared -o $OUTPUT_DIR/libimported.so $IMPORTED_C_PATH + cc -shared -o $OUTPUT_DIR/libversioned.so.2 $IMPORTED_C_PATH ;; Darwin*) - cc -shared -Wl,-install_name,@rpath/libimported.dylib -o libimported.dylib imported.c + cc -shared -Wl,-install_name,@rpath/libimported.dylib -o $OUTPUT_DIR/libimported.dylib $IMPORTED_C_PATH # According to "Mac OS X For Unix Geeks", 4th Edition, Chapter 11, versioned dylib for macOS # should be libversioned.2.dylib. - cc -shared -Wl,-install_name,@rpath/libversioned.2.dylib -o libversioned.2.dylib imported.c + cc -shared -Wl,-install_name,@rpath/libversioned.2.dylib -o $OUTPUT_DIR/libversioned.2.dylib $IMPORTED_C_PATH # However, Oracle Instant Client was distributed as libclntsh.dylib.12.1 with a unversioed # symlink (https://www.oracle.com/database/technologies/instant-client/macos-intel-x86-downloads.html). # Let's cover this non-standard case as well. - cc -shared -Wl,-install_name,@rpath/libversioned.dylib.2 -o libversioned.dylib.2 imported.c + cc -shared -Wl,-install_name,@rpath/libversioned.dylib.2 -o $OUTPUT_DIR/libversioned.dylib.2 $IMPORTED_C_PATH + cd $OUTPUT_DIR ln -fs libversioned.dylib.2 libversioned.dylib ;; *) diff --git a/tests/core/coverage/lcov_coverage_test.go b/tests/core/coverage/lcov_coverage_test.go index d882d1ee31..b2b62f5cd2 100644 --- a/tests/core/coverage/lcov_coverage_test.go +++ b/tests/core/coverage/lcov_coverage_test.go @@ -200,6 +200,7 @@ func TestLcovCoverageWithTool(t *testing.T) { args := append([]string{ "coverage", "--combined_report=lcov", + "--java_runtime_version=remotejdk_11", "//src:lib_with_tool_test", }) diff --git a/tests/integration/gazelle/gazelle_test.go b/tests/integration/gazelle/gazelle_test.go index 42ad91db12..0f29ca5800 100644 --- a/tests/integration/gazelle/gazelle_test.go +++ b/tests/integration/gazelle/gazelle_test.go @@ -53,8 +53,8 @@ func TestUpdate(t *testing.T) { } got := strings.TrimSpace(string(data)) want := strings.TrimSpace(` -load("@io_bazel_rules_go//go:def.bzl", "go_library") load("@bazel_gazelle//:def.bzl", "gazelle") +load("@io_bazel_rules_go//go:def.bzl", "go_library") # gazelle:prefix example.com/hello gazelle( diff --git a/tests/integration/popular_repos/BUILD.bazel b/tests/integration/popular_repos/BUILD.bazel index 34db3c79b6..721eec08a8 100644 --- a/tests/integration/popular_repos/BUILD.bazel +++ b/tests/integration/popular_repos/BUILD.bazel @@ -30,13 +30,15 @@ test_suite( "@org_golang_x_crypto//blowfish:blowfish_test", "@org_golang_x_crypto//bn256:bn256_test", "@org_golang_x_crypto//cast5:cast5_test", + "@org_golang_x_crypto//chacha20:chacha20_test", "@org_golang_x_crypto//chacha20poly1305:chacha20poly1305_test", "@org_golang_x_crypto//cryptobyte:cryptobyte_test", "@org_golang_x_crypto//curve25519:curve25519_test", + "@org_golang_x_crypto//curve25519/internal/field:field_test", "@org_golang_x_crypto//ed25519:ed25519_test", "@org_golang_x_crypto//hkdf:hkdf_test", - "@org_golang_x_crypto//internal/chacha20:chacha20_test", - "@org_golang_x_crypto//internal/subtle:subtle_test", + "@org_golang_x_crypto//internal/alias:alias_test", + "@org_golang_x_crypto//internal/poly1305:poly1305_test", "@org_golang_x_crypto//md4:md4_test", "@org_golang_x_crypto//nacl/auth:auth_test", "@org_golang_x_crypto//nacl/box:box_test", @@ -52,16 +54,16 @@ test_suite( "@org_golang_x_crypto//pbkdf2:pbkdf2_test", "@org_golang_x_crypto//pkcs12:pkcs12_test", "@org_golang_x_crypto//pkcs12/internal/rc2:rc2_test", - "@org_golang_x_crypto//poly1305:poly1305_test", "@org_golang_x_crypto//ripemd160:ripemd160_test", "@org_golang_x_crypto//salsa20:salsa20_test", "@org_golang_x_crypto//salsa20/salsa:salsa_test", "@org_golang_x_crypto//scrypt:scrypt_test", "@org_golang_x_crypto//sha3:sha3_test", + "@org_golang_x_crypto//ssh/internal/bcrypt_pbkdf:bcrypt_pbkdf_test", "@org_golang_x_crypto//ssh/knownhosts:knownhosts_test", - "@org_golang_x_crypto//ssh/terminal:terminal_test", "@org_golang_x_crypto//tea:tea_test", "@org_golang_x_crypto//twofish:twofish_test", + "@org_golang_x_crypto//x509roots/nss:nss_test", "@org_golang_x_crypto//xtea:xtea_test", "@org_golang_x_crypto//xts:xts_test", ], @@ -80,6 +82,7 @@ test_suite( "@org_golang_x_net//http2/h2c:h2c_test", "@org_golang_x_net//http2/hpack:hpack_test", "@org_golang_x_net//idna:idna_test", + "@org_golang_x_net//internal/quic/cmd/interop:interop_test", "@org_golang_x_net//internal/socks:socks_test", "@org_golang_x_net//internal/sockstest:sockstest_test", "@org_golang_x_net//internal/timeseries:timeseries_test", @@ -88,6 +91,8 @@ test_suite( "@org_golang_x_net//netutil:netutil_test", "@org_golang_x_net//proxy:proxy_test", "@org_golang_x_net//publicsuffix:publicsuffix_test", + "@org_golang_x_net//quic:quic_test", + "@org_golang_x_net//quic/qlog:qlog_test", "@org_golang_x_net//route:route_test", "@org_golang_x_net//trace:trace_test", "@org_golang_x_net//webdav:webdav_test", @@ -161,6 +166,7 @@ test_suite( tests = [ "@org_golang_x_tools//benchmark/parse:parse_test", "@org_golang_x_tools//cmd/benchcmp:benchcmp_test", + "@org_golang_x_tools//cmd/bisect:bisect_test", "@org_golang_x_tools//cmd/digraph:digraph_test", "@org_golang_x_tools//cmd/go-contrib-init:go-contrib-init_test", "@org_golang_x_tools//cmd/splitdwarf/internal/macho:macho_test", @@ -176,13 +182,18 @@ test_suite( "@org_golang_x_tools//godoc/vfs:vfs_test", "@org_golang_x_tools//godoc/vfs/gatefs:gatefs_test", "@org_golang_x_tools//godoc/vfs/mapfs:mapfs_test", + "@org_golang_x_tools//internal/aliases:aliases_test", + "@org_golang_x_tools//internal/analysisinternal:analysisinternal_test", + "@org_golang_x_tools//internal/bisect:bisect_test", "@org_golang_x_tools//internal/diff:diff_test", "@org_golang_x_tools//internal/diff/lcs:lcs_test", "@org_golang_x_tools//internal/diff/myers:myers_test", + "@org_golang_x_tools//internal/edit:edit_test", "@org_golang_x_tools//internal/event:event_test", "@org_golang_x_tools//internal/event/export:export_test", "@org_golang_x_tools//internal/event/export/ocagent:ocagent_test", "@org_golang_x_tools//internal/event/export/ocagent/wire:wire_test", + "@org_golang_x_tools//internal/event/keys:keys_test", "@org_golang_x_tools//internal/event/label:label_test", "@org_golang_x_tools//internal/fuzzy:fuzzy_test", "@org_golang_x_tools//internal/gopathwalk:gopathwalk_test", @@ -193,6 +204,7 @@ test_suite( "@org_golang_x_tools//internal/proxydir:proxydir_test", "@org_golang_x_tools//internal/robustio:robustio_test", "@org_golang_x_tools//internal/stack:stack_test", + "@org_golang_x_tools//internal/tokeninternal:tokeninternal_test", "@org_golang_x_tools//internal/typesinternal:typesinternal_test", "@org_golang_x_tools//playground/socket:socket_test", "@org_golang_x_tools//refactor/satisfy:satisfy_test", @@ -233,6 +245,7 @@ test_suite( build_test( name = "build_only", targets = [ + "@org_golang_x_crypto//nacl/secretbox:secretbox", "@org_golang_x_crypto//ssh/agent:agent", "@org_golang_x_crypto//ssh/test:test", "@org_golang_x_crypto//ssh:ssh", @@ -256,6 +269,7 @@ build_test( "@org_golang_x_tools//cmd/callgraph:callgraph", "@org_golang_x_tools//cmd/file2fuzz:file2fuzz", "@org_golang_x_tools//cmd/fiximports:fiximports", + "@org_golang_x_tools//cmd/gonew:gonew", "@org_golang_x_tools//cmd/gorename:gorename", "@org_golang_x_tools//cmd/signature-fuzzer/fuzz-driver:fuzz-driver", "@org_golang_x_tools//cmd/signature-fuzzer/fuzz-runner:fuzz-runner", @@ -265,6 +279,7 @@ build_test( "@org_golang_x_tools//go/analysis/analysistest:analysistest", "@org_golang_x_tools//go/analysis/multichecker:multichecker", "@org_golang_x_tools//go/analysis/passes/asmdecl:asmdecl", + "@org_golang_x_tools//go/analysis/passes/appends:appends", "@org_golang_x_tools//go/analysis/passes/assign:assign", "@org_golang_x_tools//go/analysis/passes/atomic:atomic", "@org_golang_x_tools//go/analysis/passes/atomicalign:atomicalign", @@ -276,11 +291,13 @@ build_test( "@org_golang_x_tools//go/analysis/passes/copylock:copylock", "@org_golang_x_tools//go/analysis/passes/ctrlflow:ctrlflow", "@org_golang_x_tools//go/analysis/passes/deepequalerrors:deepequalerrors", + "@org_golang_x_tools//go/analysis/passes/defers:defers", "@org_golang_x_tools//go/analysis/passes/directive:directive", "@org_golang_x_tools//go/analysis/passes/errorsas:errorsas", "@org_golang_x_tools//go/analysis/passes/fieldalignment:fieldalignment", "@org_golang_x_tools//go/analysis/passes/findcall:findcall", "@org_golang_x_tools//go/analysis/passes/framepointer:framepointer", + "@org_golang_x_tools//go/analysis/passes/httpmux:httpmux", "@org_golang_x_tools//go/analysis/passes/httpresponse:httpresponse", "@org_golang_x_tools//go/analysis/passes/ifaceassert:ifaceassert", "@org_golang_x_tools//go/analysis/passes/loopclosure:loopclosure", @@ -293,8 +310,10 @@ build_test( "@org_golang_x_tools//go/analysis/passes/shadow:shadow", "@org_golang_x_tools//go/analysis/passes/shift:shift", "@org_golang_x_tools//go/analysis/passes/sigchanyzer:sigchanyzer", + "@org_golang_x_tools//go/analysis/passes/slog:slog", "@org_golang_x_tools//go/analysis/passes/sortslice:sortslice", "@org_golang_x_tools//go/analysis/passes/stdmethods:stdmethods", + "@org_golang_x_tools//go/analysis/passes/stdversion:stdversion", "@org_golang_x_tools//go/analysis/passes/stringintconv:stringintconv", "@org_golang_x_tools//go/analysis/passes/structtag:structtag", "@org_golang_x_tools//go/analysis/passes/testinggoroutine:testinggoroutine", @@ -312,6 +331,7 @@ build_test( "@org_golang_x_tools//go/callgraph/cha:cha", "@org_golang_x_tools//go/callgraph/rta:rta", "@org_golang_x_tools//go/callgraph/vta:vta", + "@org_golang_x_tools//go/cfg:cfg", "@org_golang_x_tools//go/expect:expect", "@org_golang_x_tools//go/gccgoexportdata:gccgoexportdata", "@org_golang_x_tools//go/gcexportdata:gcexportdata", diff --git a/tests/integration/popular_repos/README.rst b/tests/integration/popular_repos/README.rst index 4a0130a8be..7824677fe4 100644 --- a/tests/integration/popular_repos/README.rst +++ b/tests/integration/popular_repos/README.rst @@ -22,13 +22,15 @@ This runs tests from the repository `golang.org/x/crypto * @org_golang_x_net//http2/h2c:h2c_test * @org_golang_x_net//http2/hpack:hpack_test * @org_golang_x_net//idna:idna_test +* @org_golang_x_net//internal/quic/cmd/interop:interop_test * @org_golang_x_net//internal/socks:socks_test * @org_golang_x_net//internal/sockstest:sockstest_test * @org_golang_x_net//internal/timeseries:timeseries_test @@ -81,6 +84,8 @@ This runs tests from the repository `golang.org/x/net * @org_golang_x_net//netutil:netutil_test * @org_golang_x_net//proxy:proxy_test * @org_golang_x_net//publicsuffix:publicsuffix_test +* @org_golang_x_net//quic:quic_test +* @org_golang_x_net//quic/qlog:qlog_test * @org_golang_x_net//route:route_test * @org_golang_x_net//trace:trace_test * @org_golang_x_net//webdav:webdav_test @@ -157,8 +162,8 @@ This runs tests from the repository `golang.org/x/tools * @org_golang_x_mod//sumdb/dirhash:dirhash_test * @org_golang_x_mod//sumdb/note:note_test * @org_golang_x_mod//sumdb/storage:storage_test + + diff --git a/tests/integration/popular_repos/popular_repos.bzl b/tests/integration/popular_repos/popular_repos.bzl index 85e9ce5736..ba53778cb0 100644 --- a/tests/integration/popular_repos/popular_repos.bzl +++ b/tests/integration/popular_repos/popular_repos.bzl @@ -33,7 +33,7 @@ def popular_repos(): go_repository, name = "org_golang_x_net", importpath = "golang.org/x/net", - commit = "3c333c0c5288a7cf127e427ddda5b1b54020a2b4", + commit = "e18ecbb051101a46fc263334b127c89bc7bff7ea", ) _maybe( go_repository, diff --git a/tests/integration/popular_repos/popular_repos.py b/tests/integration/popular_repos/popular_repos.py index b5257cdaee..eafe4b3fb2 100755 --- a/tests/integration/popular_repos/popular_repos.py +++ b/tests/integration/popular_repos/popular_repos.py @@ -23,7 +23,7 @@ importpath = "golang.org/x/crypto", commit = "0d375be9b61cb69eb94173d0375a05e90875bbf6", excludes = [ - # "internal/wycheproof:wycheproof_test", # Needs GOROOT + "internal/wycheproof:wycheproof_test", # requires build cache "nacl/secretbox:secretbox_test", # panics in salsa2020_amd64.s "ssh/agent:agent_test", "ssh/test:test_test", @@ -86,10 +86,12 @@ "cmd/callgraph:callgraph_test", # Needs testdata directory "cmd/file2fuzz:file2fuzz_test", # Requires working GOROOT, uses go build "cmd/fiximports:fiximports_test", # requires working GOROOT, not present in CI. + "cmd/deadcode:deadcode_test", # Needs GOROOT "cmd/godoc:godoc_test", # TODO(#417) + "cmd/gonew:gonew_test", # requires build cache "cmd/gorename:gorename_test", # TODO(#417) "cmd/guru/testdata/src/referrers:referrers_test", # Not a real test - "cmd/guru:guru_test", # Needs testdata directory + # "cmd/guru:guru_test", # Needs testdata directory "cmd/signature-fuzzer/fuzz-driver:fuzz-driver_test", # requires working GOROOT "cmd/signature-fuzzer/fuzz-runner:fuzz-runner_test", # requires working GOROOT "cmd/signature-fuzzer/internal/fuzz-generator:fuzz-generator_test", # requires working GOROOT @@ -99,8 +101,10 @@ "go/analysis/analysistest:analysistest_test", # requires build cache "go/analysis/internal/analysisflags:analysisflags_test", # calls os.Exit(0) in a test "go/analysis/internal/checker:checker_test", # loads test package with go/packages, which probably needs go list + "go/analysis/internal/versiontest:versiontest_test", # Needs GOROOT "go/analysis/multichecker:multichecker_test", # requires go vet "go/analysis/passes/asmdecl:asmdecl_test", # Needs testdata directory + "go/analysis/passes/appends:appends_test", # Needs GOROOT "go/analysis/passes/assign:assign_test", # Needs testdata directory "go/analysis/passes/atomic:atomic_test", # Needs testdata directory "go/analysis/passes/atomicalign:atomicalign_test", # requires go list @@ -113,11 +117,13 @@ "go/analysis/passes/copylock:copylock_test", # Needs testdata directory "go/analysis/passes/ctrlflow:ctrlflow_test", # Needs testdata directory "go/analysis/passes/deepequalerrors:deepequalerrors_test", # requires go list + "go/analysis/passes/defers:defers_test", # Needs GOROOT "go/analysis/passes/directive:directive_test", # Needs GOROOT "go/analysis/passes/errorsas:errorsas_test", # requires go list and testdata "go/analysis/passes/fieldalignment:fieldalignment_test", # Needs GOROOT "go/analysis/passes/findcall:findcall_test", # requires build cache "go/analysis/passes/framepointer:framepointer_test", # Needs GOROOT + "go/analysis/passes/httpmux:httpmux_test", # Needs GOROOT "go/analysis/passes/httpresponse:httpresponse_test", # Needs testdata directory "go/analysis/passes/ifaceassert:ifaceassert_test", # Needs GOROOT "go/analysis/passes/loopclosure:loopclosure_test", # Needs testdata directory @@ -130,8 +136,10 @@ "go/analysis/passes/shadow:shadow_test", # Needs testdata directory "go/analysis/passes/shift:shift_test", # Needs testdata director "go/analysis/passes/sigchanyzer:sigchanyzer_test", # Needs testdata directory + "go/analysis/passes/slog:slog_test", # Needs GOROOT "go/analysis/passes/sortslice:sortslice_test", # Needs 'go list' "go/analysis/passes/stdmethods:stdmethods_test", # Needs testdata directory + "go/analysis/passes/stdversion:stdversion_test", # Needs GOROOT "go/analysis/passes/stringintconv:stringintconv_test", # Needs 'go list' "go/analysis/passes/structtag:structtag_test", # Needs testdata directory "go/analysis/passes/testinggoroutine:testinggoroutine_test", # Need 'go env' @@ -153,6 +161,7 @@ "go/callgraph/cha:cha_test", # Needs testdata directory "go/callgraph/rta:rta_test", # Needs testdata directory "go/callgraph/vta:vta_test", # Needs testdata directory + "go/cfg:cfg_test", # Needs GOROOT "go/expect:expect_test", # Needs testdata directory "go/gccgoexportdata:gccgoexportdata_test", # Needs testdata directory "go/gcexportdata:gcexportdata_test", # Needs testdata directory @@ -162,7 +171,7 @@ "go/packages/packagestest/testdata:testdata_test", # Is testdata "go/packages/packagestest:packagestest_test", # requires build cache "go/packages:packages_test", # Hah! - "go/pointer:pointer_test", # Needs testdata directory + # "go/pointer:pointer_test", # Needs testdata directory "go/ssa/interp:interp_test", # Needs testdata directory "go/ssa/ssautil:ssautil_test", # Needs testdata directory "go/ssa:ssa_test", # Needs testdata directory @@ -173,11 +182,17 @@ "godoc:godoc_test", # requires GOROOT and GOPATH "internal/apidiff:apidiff_test", # Needs testdata directory "internal/diff/difftest:difftest_test", # Needs diff tool + "internal/diffp:diffp_test", # Needs testdata directory "internal/facts:facts_test", # loads test package with go/packages, which probably needs go list "internal/gcimporter:gcimporter_test", # Needs testdata directory "internal/gocommand:gocommand_test", # Needs go tool "internal/imports:imports_test", # Needs testdata directory + "internal/pprof:pprof_test", # Needs testdata directory + "internal/refactor/inline:inline_test", # Needs GOROOT + "internal/refactor/inline/analyzer:analyzer_test", # Needs GOROOT "internal/typeparams:typeparams_test", # Needs go tool + "internal/testfiles:testfiles_test", # Needs testdata directory + "internal/versions:versions_test", # Needs GoVersion "present:present_test", # Needs goldmark "refactor/eg:eg_test", # Needs testdata directory "refactor/importgraph:importgraph_test", # TODO(#417) @@ -185,6 +200,7 @@ ], build_excludes = [ "blog:blog", # requires present + "cmd/deadcode:deadcode", # requires x_telemetry "cmd/godoc:godoc", # requires godoc "godoc:godoc", # requires goldmark "present:present", # Needs goldmark