Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make builds fail to land in $$BUILD_TMPDIR$$ #797

Closed
fmeum opened this issue Oct 5, 2021 · 0 comments · Fixed by #818
Closed

make builds fail to land in $$BUILD_TMPDIR$$ #797

fmeum opened this issue Oct 5, 2021 · 0 comments · Fixed by #818

Comments

@fmeum
Copy link
Member

fmeum commented Oct 5, 2021

I am not yet sure why, but some of my make builds of third-party libraries fail due to the use of $$EXT_BUILD_ROOT$$/{root} instead of $$BUILD_TMPDIR$$ in:
https://github.com/bazelbuild/rules_foreign_cc/blob/a7105dafb067c785cc9ade2c70b0d0ce967490fc/foreign_cc/make.bzl#L59
All of my builds pass with $$BUILD_TMPDIR$$ in that spot, which is also the value used by configure_make.
Edit: There are some issues with dangling symlinks with that change in other builds.

@UebelAndre Could you briefly explain why some rules use $$EXT_BUILD_ROOT$$/{root} and others use $$BUILD_TMPDIR$$? If I understand this a bit better, I could probably start working on a PR that fixes the build issues I am seeing without introducing new ones.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant