Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cuda_test missing alwayslink #202

Closed
skyw opened this issue Dec 29, 2023 · 2 comments · Fixed by #210
Closed

cuda_test missing alwayslink #202

skyw opened this issue Dec 29, 2023 · 2 comments · Fixed by #210

Comments

@skyw
Copy link

skyw commented Dec 29, 2023

For the reason discussed in #20

_cuda_library inside cuda_test macro needs alwayslink=True. I don't know if there are side effects to set it by default. So filed an issue instead of a PR to add a line.

@cloudhan
Copy link
Collaborator

Reasonable, along with cuda_binary.

But that somehow creates implication on the hidden target, will there be some harmful case if we always set alwayslink=True.

Or should we add it implicitly on the hidden target or explicitly on the macro so that to avoid of macro copy pasting in some edge cases?

@skyw
Copy link
Author

skyw commented Jan 4, 2024

I would prefer "implicitly on the hidden target" if we can do it safely. Otherwise, exposing it to the macro would do it.
Currently some work around is needed one way or another.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants