Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add attribute tags #179

Closed
hofbi opened this issue Oct 11, 2023 · 5 comments
Closed

Add attribute tags #179

hofbi opened this issue Oct 11, 2023 · 5 comments

Comments

@hofbi
Copy link
Contributor

hofbi commented Oct 11, 2023

Many people might want to tag their cuda targets with gpu or something, hence it would be nice to add a tags attribute to cuda_libary and cuda_object

@cloudhan
Copy link
Collaborator

cloudhan commented Oct 11, 2023

Do we need to manually add it as an attribute? https://bazel.build/reference/be/common-definitions?hl=en#common-attributes claims it is common to all build rules, I am not sure if it apply to user defined rules or not.

@hofbi
Copy link
Contributor Author

hofbi commented Oct 11, 2023

I expected that this should work by default but for some reason passing a tag does not work.

@ryanleary
Copy link
Collaborator

@hofbi do you have a repro for this? I'll confirm tomorrow, but I'm pretty sure we have cuda targets with tags in some of our projects working as expected.

@hofbi
Copy link
Contributor Author

hofbi commented Jan 10, 2024

Sorry, nothing that I can share. Let me double check, maybe it works meanwhile.

@hofbi
Copy link
Contributor Author

hofbi commented Jan 10, 2024

Looks like it is working now. We can close this one.

@hofbi hofbi closed this as completed Jan 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants