-
-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add attribute tags
#179
Comments
Do we need to manually add it as an attribute? https://bazel.build/reference/be/common-definitions?hl=en#common-attributes claims it is common to all build rules, I am not sure if it apply to user defined rules or not. |
I expected that this should work by default but for some reason passing a tag does not work. |
@hofbi do you have a repro for this? I'll confirm tomorrow, but I'm pretty sure we have cuda targets with tags in some of our projects working as expected. |
Sorry, nothing that I can share. Let me double check, maybe it works meanwhile. |
Looks like it is working now. We can close this one. |
Many people might want to tag their cuda targets with
gpu
or something, hence it would be nice to add atags
attribute tocuda_libary
andcuda_object
The text was updated successfully, but these errors were encountered: