-
-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add toolchain param to affected actions #668
base: main
Are you sure you want to change the base?
Conversation
Hi @alexeagle, Nevena here from Bazel team in Munich! :) Can you please take a look at this PR? |
Looks like this needs a |
@alexeagle Do you think we want this backported to the |
We can say that bazel-lib 1.x doesn't support Bazel 7.0 so I don't think we need to backport this. If someone complains I can revisit. |
@kotlaja I tried to update the docs for you, but you didn't check the "allow maintainers to add commits" box
|
Sorry, I was on a vacation. Thanks for the help here! Hm, |
@kotlaja i meant to speak with somebody from bazel team about this. does adding this parameter make the action incompatible with older versions of bazel where this attribute isn't recognized or does it get simply ignored? |
This is part of migrations of Automatic Exec Groups (AEGs) where a
toolchain
parameter should be set inside actions which use executable or tools from a toolchain.AEGs are under an incompatible flag right now, but will be flipped soon in Bazel 7. I've added this change since I was manually fixing rules_nodejs, which depends on bazel-lib. I can't fully test this change since I need at least Bazel 7, but Bazel@Head raises non related errors to my change. That's why there might be more related updates once bazel-lib supports Bazel 7.
Still, as I already mentioned, adding a toolchain parameter is masked by the incompatible flag, so these changes don't do anything right now. But it can help you with your migration in the near future when AEGs are enabled by default and you are forced to update actions which use toolchains.
Also note that the
toolchain
parameter is available from Bazel 6, but the full logic (and the incompatible flag) will be available from Bazel 7.Please check official documentation for Automatic Exec Groups for additional info.
Type of change
Test plan
--incompatible_auto_exec_groups
flag.