collapsable sidebar with nice transition #878
Open
+142
−20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ality to sidebar when mobile, need to make it look better
|
Hmmm... I think i might prefer the old popup menu on mobile? Here's a screenshot of what the sidebar opening looks like on my local on mobile. I do love the responsiveness and animations on the collapsing though 🔥. Let me know what you think @nour-massri 🚀
|
|
hmm I don't think the shifted content is a problem but yeah the long sidebar is definitely an issue, I had an ideas of making it smaller when it is on mobile but honestly keeping the old menu might be the move for now |
…tton to control menu on mobile and sidebar on desktop
nour-massri
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #824
still needs some work to make it look better
ideas: