Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor z position update in transformed MCMC #467

Merged
merged 2 commits into from
Dec 17, 2024
Merged

Conversation

Micki-D
Copy link
Collaborator

@Micki-D Micki-D commented Dec 16, 2024

This PR changes the way the sample_zobject is updated during transformed mcmc.
Now, a new DensitySampleVector with the updated z samples is created, which is then used in a new mcmc chain state via @set from Accessors.jl

Copy link

codecov bot commented Dec 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 49.63%. Comparing base (159f24f) to head (cf55f25).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #467      +/-   ##
==========================================
+ Coverage   49.51%   49.63%   +0.11%     
==========================================
  Files         121      121              
  Lines        5812     5815       +3     
==========================================
+ Hits         2878     2886       +8     
+ Misses       2934     2929       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@oschulz oschulz merged commit 250a969 into main Dec 17, 2024
11 checks passed
@oschulz
Copy link
Member

oschulz commented Dec 17, 2024

Thanks!

@oschulz oschulz deleted the z_update_refactor branch December 17, 2024 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants