Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manually set lower bounds on direct deps #466

Merged
merged 2 commits into from
Dec 12, 2024

Conversation

fhagemann
Copy link

@fhagemann fhagemann commented Dec 12, 2024

I manually went through all direct dependencies and increased the lower bounds such that they are compatible with each other.

I did NOT check the weakdeps!

Summary:

BAT imports likelihoodof and StdNormal from MeasureBase, which were introduced only in v0.14. I manually adjusted this compat.

The rest is because of:

Copy link

codecov bot commented Dec 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 48.23%. Comparing base (c9a4192) to head (5e498b1).
Report is 2 commits behind head on releases/3.

Additional details and impacted files
@@             Coverage Diff             @@
##           releases/3     #466   +/-   ##
===========================================
  Coverage       48.23%   48.23%           
===========================================
  Files             112      112           
  Lines            5424     5424           
===========================================
  Hits             2616     2616           
  Misses           2808     2808           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@oschulz oschulz merged commit de27f58 into bat:releases/3 Dec 12, 2024
10 checks passed
@oschulz
Copy link
Member

oschulz commented Dec 12, 2024

Thanks for deep look at this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants