Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include sample_z in _cleanup_samples() #462

Merged
merged 1 commit into from
Nov 16, 2024
Merged

Include sample_z in _cleanup_samples() #462

merged 1 commit into from
Nov 16, 2024

Conversation

Micki-D
Copy link
Collaborator

@Micki-D Micki-D commented Nov 15, 2024

This fixes a bug that arises when '_cleanup_samples()' is called when the last proposed sample in the chain has been accepted.
This would cause the samples stored in the chain_state to be cleaned up, but the sample_z would remain in the old state, causing faulty subsequent steps.

Copy link

codecov bot commented Nov 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 49.51%. Comparing base (4d2f76b) to head (a7662fe).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #462      +/-   ##
==========================================
+ Coverage   49.47%   49.51%   +0.04%     
==========================================
  Files         121      121              
  Lines        5807     5812       +5     
==========================================
+ Hits         2873     2878       +5     
  Misses       2934     2934              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@oschulz oschulz merged commit 62c600d into main Nov 16, 2024
11 checks passed
@oschulz
Copy link
Member

oschulz commented Nov 16, 2024

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants