Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

not pulling in node_helper #29

Open
JPMinAR opened this issue Nov 4, 2019 · 3 comments
Open

not pulling in node_helper #29

JPMinAR opened this issue Nov 4, 2019 · 3 comments
Assignees

Comments

@JPMinAR
Copy link

JPMinAR commented Nov 4, 2019

So took me a little bit to determine what was happening but since I have a 'modules' directory mapped to my docker instance it does not include the /modules/node_modules/node_helper/index.js dependency that multiple applications assume to be present.

Can the fact that this needs to be included in the mapped modules instance or could this be conditionally copied over as part of the 'else' condition of the 'docker-entrypoint.sh' so as to eliminate confusion from user that are not aware of this required dependency.

@bastilimbach bastilimbach self-assigned this Nov 16, 2019
@sdetweil
Copy link

that node module is included in the default git clone install as part of the base.

I have submitted an update to the master MagicMirror repo to load this node_helper.js class module differently, so it will be present as part of npm install
I hope that it will be accepted in version 2.10

@bastilimbach
Copy link
Owner

@sdetweil Is this solved?

@sdetweil
Copy link

sdetweil commented Apr 2, 2020

Yes. It is located in the js folder now, with an alias in package.json.

So u need both changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants