Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does not open relative paths #59

Closed
paulvi opened this issue Aug 27, 2014 · 5 comments
Closed

Does not open relative paths #59

paulvi opened this issue Aug 27, 2014 · 5 comments

Comments

@paulvi
Copy link
Contributor

paulvi commented Aug 27, 2014

I came across that this nice plugin does not open relative paths like

..\\..\\..\\..\\mobile\\android\\Library\\src\\fastjson\\1.1.33\\fastjson\\src

of course i can Ctrl+Alt+D to open shell and execute

cd ..\\..\\..\\..\\mobile\\android\\Library\\src\\fastjson\\1.1.33\\fastjson\\src
@basti1302
Copy link
Collaborator

Are we talking about opening a shell/explorer from a text file? So, in your case, you have the text ..\\..\\..\\..\\mobile\\android\\Library\\src\\fastjson\\1.1.33\\fastjson\\src in a text file, select this text in the editor and press Ctrl+Alt+D?

If so, relative to which directory should the path be interpreted? Relative to the current working dir of the Eclipse process? Relative to the project directory of the current project? Relative to the file you have in the editor? Relative to the user home?

There are many possibilities and depending on the use case, each user might have a different expectation.

@paulvi
Copy link
Contributor Author

paulvi commented Sep 15, 2014

Oh, I should put you into context

Eclipse lets users to configure where are jar sources via .jar.properties file with content like

src=D:\\adt-bundle-windows-x86_64-20140321\\sdk\\extras\\android\\support\\v4\\src

Of course relative paths are better, but they may be too long and harder to check.

When I tried to use StartExplorer to check if such relative path is correct, it failed to open with Explorer.

e.g. ..\\..\\..\\..\\..\\Library\\src\\afinal\\0.5.1\\src

startexplorer-relative-path-2

If so, relative to which directory should the path be interpreted?

As you should see by now, it is current file / Editor path.

@basti1302
Copy link
Collaborator

So, just to avoid misunderstandings: Your expectation was to resolve the path relative to the file that is currently open in the editor? Is this correct?

@paulvi
Copy link
Contributor Author

paulvi commented Sep 16, 2014

Your expectation was to resolve the path relative to the file that is currently open in the editor? Is this correct?

Yes.
When path is in Editor, it should be the path of current opened file.
This is most logical.

@basti1302
Copy link
Collaborator

Feature is implemented in release 1.6.1. Check it out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants