Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add kwargs to ChempropNeuralFP.__init__ #31

Closed
c-w-feldmann opened this issue Jun 20, 2024 · 0 comments · Fixed by #32
Closed

Add kwargs to ChempropNeuralFP.__init__ #31

c-w-feldmann opened this issue Jun 20, 2024 · 0 comments · Fixed by #32
Labels
status: completed Issue that was successfully solved type: bug Something isn't working

Comments

@c-w-feldmann
Copy link
Collaborator

Currently cloning the ChempropNeuralFP raises this error:

TypeError: ChempropNeuralFP.__init__() got an unexpected keyword argument 'lightning_trainer__accelerator'

I suspect that this comes from a missing a missing kwargs which forwards lightning_trainer params to ABCChemprop which handles them.
@c-w-feldmann c-w-feldmann added type: bug Something isn't working status: doing Issue is currently addressed labels Jun 20, 2024
@c-w-feldmann c-w-feldmann linked a pull request Jun 20, 2024 that will close this issue
31 add kwargs to chempropneuralfp init #32
Merged
@c-w-feldmann c-w-feldmann added status: completed Issue that was successfully solved and removed status: doing Issue is currently addressed labels Jun 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
status: completed Issue that was successfully solved type: bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

31 add kwargs to chempropneuralfp init basf/MolPipeline
1 participant
@c-w-feldmann