Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version 1.9.1 is broken #1043

Closed
bhtabor opened this issue Oct 3, 2024 · 1 comment
Closed

Version 1.9.1 is broken #1043

bhtabor opened this issue Oct 3, 2024 · 1 comment
Assignees

Comments

@bhtabor
Copy link

bhtabor commented Oct 3, 2024

This issue is related to the discussion on #996 (comment)

Perhaps the relaxed safe.directory should be released as v1.9.2 as well. While upgrading, I had to use the following to make the deployment work on Linux.

docker build -t ghcr.io/basecamp/kamal:v1.9.1-fix - <<EOF
FROM ghcr.io/basecamp/kamal:v1.9.1

RUN git config --global --add safe.directory '*'
EOF

alias kamal='docker run -it --rm -v "${PWD}:/workdir" -v "${SSH_AUTH_SOCK}:/ssh-agent" -v /var/run/docker.sock:/var/run/docker.sock -e "SSH_AUTH_SOCK=/ssh-agent" ghcr.io/basecamp/kamal:v1.9.1-fix'

This was the error on v1.9.1

ERROR (SSHKit::Command::Failed): git exit status: 32768
git stdout: Nothing written
git stderr: Cloning into 'workdir'...
fatal: detected dubious ownership in repository at '/workdir/.git'
To add an exception for this directory, call:

	git config --global --add safe.directory /workdir/.git
fatal: Could not read from remote repository.

Please make sure you have the correct access rights
and the repository exists.
@dhh dhh assigned djmb Oct 4, 2024
@djmb
Copy link
Collaborator

djmb commented Oct 6, 2024

I've backported that fix into 1-9-stable and released 1.9.2 👍

@bhtabor bhtabor closed this as completed Oct 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants