Improve function APIs with better generics #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wilsoncusack
commented
Aug 31, 2023
wilsoncusack
commented
Aug 31, 2023
wilsoncusack
commented
Aug 31, 2023
wilsoncusack
commented
Aug 31, 2023
zencephalon
reviewed
Aug 31, 2023
wilsoncusack
force-pushed
the
wilson/new-chain-types
branch
from
ecb71af to
7252ce6
Compare
…nd also the errors that get thrown
wilsoncusack
force-pushed
the
wilson/new-chain-types
branch
from
8e02299 to
c1db23a
Compare
wilsoncusack
had a problem deploying
to
verify
GitHub Actions
Failure
…pe abstraction that allows for them
wilsoncusack
had a problem deploying
to
verify
GitHub Actions
Failure
wilsoncusack
had a problem deploying
to
verify
GitHub Actions
Failure
wilsoncusack
had a problem deploying
to
verify
GitHub Actions
Failure
wilsoncusack
had a problem deploying
to
verify
GitHub Actions
Failure
wilsoncusack
commented
Sep 2, 2023
Comment on lines
38
to
+39
| "@eth-optimism/contracts-ts": "^0.15.0", | ||
| "@roninjin10/rollup-chains": "^0.0.3", | ||
| "@wagmi/chains": "^1.7.0", | ||
| "viem": "^1.4.2", | ||
| "wagmi": "^1.3.9" | ||
| "viem": "^1.9.5" |
wilsoncusack
commented
Sep 2, 2023
| TChain, | ||
| TChainOverride | ||
| >, | ||
| // TODO consider moving GetL2ChainId to make this even more generic |
There was a problem hiding this comment.
i.e. we could move it out of this type and append it just in time in some places, or possibly we could simplify and do like targetChain instead of L2ChainId. But the name has to work for both reads and writes. I.e. to doesn't work cause in some cases we are specifying where we want to read data.
There was a problem hiding this comment.
Actually, in the case of L2 -> L1 actions we never pass the L1 chain ID. It should be known. So maybe this is fine. But we could update these types to have L1 and L2 base write actions
wilsoncusack
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.