Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flesh out docs #41

Merged
merged 13 commits into from
Sep 3, 2023
Merged

Flesh out docs #41

merged 13 commits into from
Sep 3, 2023

Conversation

zencephalon
Copy link
Collaborator

No description provided.

@zencephalon zencephalon temporarily deployed to verify August 31, 2023 17:04 — with GitHub Actions Inactive
@zencephalon zencephalon mentioned this pull request Aug 31, 2023
Closed
@zencephalon zencephalon temporarily deployed to verify August 31, 2023 17:14 — with GitHub Actions Inactive
@zencephalon zencephalon temporarily deployed to verify August 31, 2023 17:29 — with GitHub Actions Inactive
@zencephalon zencephalon temporarily deployed to verify August 31, 2023 17:42 — with GitHub Actions Inactive
wilsoncusack
wilsoncusack reviewed Sep 2, 2023
View reviewed changes
@wilsoncusack wilsoncusack temporarily deployed to verify September 2, 2023 19:25 — with GitHub Actions Inactive
wilsoncusack
wilsoncusack reviewed Sep 2, 2023
View reviewed changes
src/actions/wallet/L1/writeUnsafeDepositTransaction.ts Outdated
/**
* Write directly to the Portal proxy to deposit ETH to L2
*
* @param {Address} to the address to send the transaction to
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we probably want to note that these are all wrapped as args, and that all WriteContractParameters can also added

@wilsoncusack wilsoncusack temporarily deployed to verify September 3, 2023 02:32 — with GitHub Actions Inactive
@wilsoncusack
Copy link
Collaborator

wilsoncusack commented Sep 3, 2023 •
edited
Loading

I am satisfied with the state of docs for unsafeWrite.. I think and we can maybe use that as the template for the others. ChatGPT may also help if we show it the code and those docs and asking it to make similar docs for new code. Merging this so we can start to work on smaller chunks

@wilsoncusack wilsoncusack merged commit fd4ecdb into main Sep 3, 2023
@wilsoncusack wilsoncusack deleted the flesh-out-docs-site branch September 3, 2023 02:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wilsoncusack wilsoncusack wilsoncusack left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zencephalon @wilsoncusack