Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

optional dependencies not optional #54

Closed
fruce-ki opened this issue May 2, 2018 · 2 comments
Closed

optional dependencies not optional #54

fruce-ki opened this issue May 2, 2018 · 2 comments
Assignees
@fruce-ki
Labels
bug RATs not behaving the way it is intended to.

Comments

@fruce-ki
Copy link
Collaborator

fruce-ki commented May 2, 2018

shiny, wasabi and ggplot2 are intended to be optional dependencies.
However, in practice, R mandates their presence in order to install rats.
@fruce-ki fruce-ki added the bug RATs not behaving the way it is intended to. label May 2, 2018
@fruce-ki fruce-ki self-assigned this May 2, 2018
@fruce-ki
Copy link
Collaborator Author

fruce-ki commented May 2, 2018

This is an issue with how the dependencies were declared.

@fruce-ki
Copy link
Collaborator Author

fruce-ki commented May 2, 2018

Should be fixed now.
The code in rats has been refactored so as to not import the namespaces of shiny, wasabi, rhdf5 and ggplot2, and they are now listed as "suggested" packages.

@fruce-ki fruce-ki closed this as completed May 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fruce-ki fruce-ki

Labels
bug RATs not behaving the way it is intended to.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@fruce-ki