Service Provider 'defer' boolean property has been deprecated since 5.8, Why is it still in the package?

[yelnyafacee]

The defer boolean property on the service provider which is/was used to indicate if a provider is deferred has been deprecated. In order to mark the service provider as deferred it should implement the Illuminate\Contracts\Support\DeferrableProvider contract. - Laravel

so why is the:

protected $defer = true;

still in IdeHelperServiceProvider?

also if public function boot() exist, how can it be deferrable?

[mfn]

also if public function boot() exist, how can it be deferrable?

Hmmm 🤔

Good point. I guess it's a non-issue in practice because no one references the registered services out of context etc.

[mfn]

I guess it's a non-issue in practice

I didn't want to imply this shouldn't be fixed though 😅

[mfn]

I double checked with the docs and yep, as long as there's a boot, the deferred is useless the way I see it.

Even at the time the deferred was switched on, there was already a boot method, can be seen at a916da0 when you expand the rest of the file a bit.

Maybe back then it did something but nowadays (I'm "almost" sure) , deferred only works when you truly only register/provides and nothing else.

[barryvdh]

'back then' it worked by setting the provides() method to see when it was needed. So it wouldn't be loaded on web requests, only on the console when certain commands were executed. Not sure how deferred works now.

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.
If this issue is still present on the latest version of this library on supported Laravel versions, please let us know by replying to this issue so we can investigate further.
Thank you for your contribution! Apologies for any delayed response on our side.

[barryvdh]

I guess we can just remove the property

[mfn]

We've PR #914 which removes it but also switches to the new way since >= L6 using the marker interface.

However as mentioned there, this can't be merged as long as 5.5 is still supported and we don't even have tests to catch this.

I would suggest to be pragmatic and merge #914 for a release in September were we also bump composer and drop 5.5 for good, as the LTS is definitely over by then:

[mfn]

This was all long ago, merged and released -> property is gone.