Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract open-graph.js to separate library #44

Open
jamietanna opened this issue Mar 14, 2022 · 3 comments
Open

Extract open-graph.js to separate library #44

jamietanna opened this issue Mar 14, 2022 · 3 comments

Comments

@jamietanna
Copy link
Contributor

jamietanna commented Mar 14, 2022

As you're aware, I'm planning on migrating my Micropub endpoint to Vibrancy at some point.

In the meantime, I've spotted that this would be a good pipe for OpenGraph to i.e. Microformats2, as it'd allow me to make use of this from my current Micropub server, which doesn't have a library handy for OpenGraph parsing.

I'm happy doing this myself, as the code is MIT'd, but thought I'd check with you before doing this in case you'd like to create/maintain the underlying library.

@jamietanna
Copy link
Contributor Author

I've picked this up btw, currently at https://www.npmjs.com/package/@jamietanna/opengraph-mf2, and if you're happy I can get a PR raised to integrate this back into Vibrancy. There are some breaking changes (i.e. I return an MF2 Object with a type)

I'm also happy to discuss this being shared ownership / owned by the IndieWeb org.

@barryf
Copy link
Owner

barryf commented Mar 14, 2022

No worries, @jamietanna. Feel free to do so. I hadn't read about pipes - I like the concept 😄

@barryf barryf closed this as completed Mar 14, 2022
@jamietanna
Copy link
Contributor Author

Awesome! Mind if I keep this issue open as a reminder to loop back and migrate this? Or shall I raise a separate issue?

@barryf barryf reopened this Mar 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants