-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sec-WebSocket-Protocol header missing in Upgrade response #792
Comments
Can you provide more details about your patch, at best a complete diff or with file and line number. |
Here you go:
|
Proto is not supported currently, I just opened a PR, this introduces a new proto specific api: websock_accept_proto(connp, "sip",....); |
As far as I see, the Sec-WebSocket-Protocol header is mandatory in both the request and the 101 response, so the functions without a protocol will never be valid, right? Edit: The source I found that mentions the header is This sounded like it is not optional. But apparently it is. So nevermind. |
That pull request just adds new functions, but transp.c/http_req_handler() needs to call the new one or it still won't work. |
This causes chrome, and probably other webkit-based browsers, to fail the ws connection with an error 1006.
fix: add a line to the http_reply call in websock_accept()
"Sec-WebSocket-Protocol: sip\r\n"
The text was updated successfully, but these errors were encountered: