Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve e2e tests #6

Closed
sagikazarmark opened this issue Jun 11, 2023 · 0 comments · Fixed by bank-vaults/secrets-webhook#105
Closed

Improve e2e tests #6

sagikazarmark opened this issue Jun 11, 2023 · 0 comments · Fixed by bank-vaults/secrets-webhook#105
Labels
kind/enhancement Categorizes issue or PR as related to an improvement. lifecycle/keep Denotes an issue or PR that should be preserved from going stale.

Comments

@sagikazarmark
Copy link
Member

sagikazarmark commented Jun 11, 2023 •
edited
Loading

Current e2e tests are rather simplistic.

A couple ideas to improve test coverage:

  • Test mutated pods (initContainer and volume injected)
  • Execute vault-env in the pod and test the output
@sagikazarmark sagikazarmark moved this from 🆕 New to 📋 Backlog in Project backlog Jun 14, 2023
@ramizpolic ramizpolic self-assigned this Jun 21, 2023
@ramizpolic ramizpolic moved this from 📋 Backlog to 🔖 Ready in Project backlog Jun 21, 2023
@ramizpolic ramizpolic removed their assignment Jun 27, 2023
@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR that has become stale and will be auto-closed. label Dec 3, 2023
@ramizpolic ramizpolic added lifecycle/keep Denotes an issue or PR that should be preserved from going stale. and removed lifecycle/stale Denotes an issue or PR that has become stale and will be auto-closed. labels Dec 4, 2023
@csatib02 csatib02 mentioned this issue Jun 30, 2024
Merged
@bank-vaults bank-vaults deleted a comment from github-actions bot Jun 30, 2024
@github-project-automation github-project-automation bot moved this from 🔖 Ready for work to ✅ Done in Project backlog Aug 8, 2024
@csatib02 csatib02 added the kind/enhancement Categorizes issue or PR as related to an improvement. label Aug 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/enhancement Categorizes issue or PR as related to an improvement. lifecycle/keep Denotes an issue or PR that should be preserved from going stale.
Projects
Project backlog
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: improve e2e tests bank-vaults/secrets-webhook
3 participants
@sagikazarmark @ramizpolic @csatib02