feat: support _json_key when mutating docker credentials #91
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Auth
field of typeinterface{}
, because this way when a_json_key
is received under theauth
key of a.dockerconfigjson
it can be handled._json_key
and another check, if a vault path is received upfront at theauth
key.Fixes: bank-vaults/vault-secrets-webhook#81
Notes for reviewers
dockerconfigjson
secrets. The passing e2e tests prove that the already implemented username, password authentication option is still working.After mutation:
After mutation:
After mutation:
e2e-secret after mutation: