Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dashboard: List groups starting from the most recently created #344

Closed
vplasencia opened this issue Dec 14, 2023 · 8 comments · Fixed by #364
Closed

Dashboard: List groups starting from the most recently created #344

vplasencia opened this issue Dec 14, 2023 · 8 comments · Fixed by #364
Assignees
Labels
good first issue Good for newcomers refactoring ♻️ A code change that neither fixes a bug nor adds a feature
Milestone

Comments

@vplasencia
Copy link
Member

vplasencia commented Dec 14, 2023

Right now they are listed ordered alphabetically.

@vplasencia vplasencia added the refactoring ♻️ A code change that neither fixes a bug nor adds a feature label Dec 14, 2023
@vplasencia vplasencia added this to the 3. Tethys milestone Dec 14, 2023
@vplasencia vplasencia modified the milestones: 3. Tethys, 4. Dione Jan 2, 2024
@aguzmant103 aguzmant103 added the good first issue Good for newcomers label Jan 3, 2024
@tanyas-codes
Copy link
Contributor

hey ! i love this project ! can i take up this issue?

@vplasencia
Copy link
Member Author

Hey @tanyas-codes thank you. Yes, sure. Do you want me to assign you this issue?

@tanyas-codes
Copy link
Contributor

yes !

@vplasencia
Copy link
Member Author

Done! Let us know if you need any help @tanyas-codes! 👍

@tanyas-codes
Copy link
Contributor

hey ! i am done with listing the groups based on recent creation:
->Off-chains groups are listed based on recents but the same is not possible for the on-chain groups (on-chain groups are still getting sorted alphabetically)
->i used console.log to check the api response and their properties, and it seems like there is a" createdAt" property for off-chain groups (through which i was able to sort them)
But the on-chain groups has no such "createdAt" property returned from the "semaphoreAPI" api response .

I checked the semaphore documentation and there was no mention of any property that returns back the time of creation ,digging deeper i found there might be a way to change the schema and maybe add a " timestamp " whenever a new block is created so maybe changes ,must be made to the semaphoreAPI
https://docs.semaphore.pse.dev/subgraph
https://docs.semaphore.pse.dev/guides/fetching-data

adding images below which show that off-chain groups are sorted based on latest creation time but not the same for on-chain groups .
console log-onchain
consolelog-offchain
off-chain
on-chain

@vplasencia
Copy link
Member Author

Hey @tanyas-codes this is great! Thank you so much! Do you want to create a PR to merge your changes?

@tanyas-codes
Copy link
Contributor

thankyou !yes , i will create a PR

can u add a new issue/bug for the semaphore api ,the on-chain groups are still sorted alphabetically and not based on recent creation.

@vplasencia
Copy link
Member Author

Hey! Yes, for now, it's fine to have only the off-chain groups sorted by creation. I will create an issue to do the same for on-chain groups later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers refactoring ♻️ A code change that neither fixes a bug nor adds a feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants