Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typing ImageHeaderScrollView && TriggeringView #97

Open
HeyrendtCh opened this issue Feb 16, 2021 · 1 comment
Open

Typing ImageHeaderScrollView && TriggeringView #97

HeyrendtCh opened this issue Feb 16, 2021 · 1 comment

Comments

@HeyrendtCh
Copy link

Hi, we have some problems with the ImageHeaderScrollView, a lot of props are necessary and some types are strange.

For example, when we updated our version of your plugin we got errors because of those types

renderFixedForeground: () => React.ElementType;
renderForeground?: () => React.ElementType;

Why it's not :

renderFixedForeground: () => React.Element;
renderForeground?: () => React.Element;

Like I mentioned, a lot of props are necessary but they are not useful for a basic utilisation :

image

We tried to copy/past your example (in the official doc) and we got a lot of errors,

In our case, we overloaded the index file and we fixed it with our on patch and finally it worked but we want to know if it's a mistake or if we miss something ?

Thank you in advance

@Spoutnik97
Copy link
Contributor

Hi, thanks for your feedback. I take back this repo after a long period of inactivity by an other collegue. Maybe I have not tested correctly the new version. Could you make a PR to propose your modifcations please ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants