Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[New Feature]: Support snippets in code action text edits #38380

Closed
IMS94 opened this issue Oct 25, 2022 · 1 comment
Closed

[New Feature]: Support snippets in code action text edits #38380

IMS94 opened this issue Oct 25, 2022 · 1 comment
Labels
Area/CodeAction Language Server Code Actions IceBox Older issues that are not being actively worked on but may be revisited in the future. Priority/Low Team/LanguageServer Language Server Implementation related issues. #Compiler Type/NewFeature userCategory/Editor

Comments

@IMS94
Copy link
Contributor

IMS94 commented Oct 25, 2022 •
edited
Loading

Description

With microsoft/language-server-protocol#592 LSP 3.18 will add support for snippets in code action text edits.

Seems like VSCode already supports that microsoft/vscode#145374. If so, we should be able to use snippet text edits without the new LSP version.

This will be a major improvement since writing/editing names, etc in text edits applied by code actions will be easier with this.

Describe your problem(s)

Right now, we can't have placeholders inside text edits returned by code actions

Describe your solution(s)

Use Snippet text edits coming in 3.18 of LSP

Related area

-> Editor
@IMS94 IMS94 added Type/NewFeature Team/LanguageServer Language Server Implementation related issues. #Compiler Area/CodeAction Language Server Code Actions labels Oct 25, 2022
@IMS94 IMS94 changed the title [New Feature]: Support snippets in code actions [New Feature]: Support snippets in code action text edits Oct 25, 2022
@ballerina-bot ballerina-bot added needTriage The issue has to be inspected and labeled manually userCategory/Editor labels Oct 25, 2022
@IMS94 IMS94 removed the needTriage The issue has to be inspected and labeled manually label Oct 26, 2022
@anupama-pathirage anupama-pathirage added the IceBox Older issues that are not being actively worked on but may be revisited in the future. label Nov 20, 2024
@anupama-pathirage
Copy link
Contributor

We are closing this issue due to inactivity. If you need further assistance or have additional input, feel free to reopen it. Thank you for helping us maintain a relevant and focused issue list!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area/CodeAction Language Server Code Actions IceBox Older issues that are not being actively worked on but may be revisited in the future. Priority/Low Team/LanguageServer Language Server Implementation related issues. #Compiler Type/NewFeature userCategory/Editor
Projects
Ballerina Team Main Board
Archived in project
Milestone
No milestone
Development

No branches or pull requests
4 participants
@IMS94 @anupama-pathirage @ballerina-bot @KavinduZoysa