Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove restrictions on docker labels #1949

Closed
pipex opened this issue May 19, 2022 · 1 comment · Fixed by #2000
Closed

Remove restrictions on docker labels #1949

pipex opened this issue May 19, 2022 · 1 comment · Fixed by #2000
Labels
low-hanging fruit Easy to fix issue

Comments

@pipex
Copy link
Contributor

pipex commented May 19, 2022

The supervisor restricts docker labels to /^[a-zA-Z][a-zA-Z0-9\.\-]*$/ according to docker recommendations.

In reality, the moby engine doesn't impose restrictions on docker labels, which is why services like traefik and caddy-docker-proxy make use of specially formatted labels to configure intra-container routing.

Relaxing the restrictions would give an extra configuration option for users
@pipex pipex added the low-hanging fruit Easy to fix issue label May 19, 2022
@jellyfish-bot
Copy link

[pipex] This issue has attached support thread https://jel.ly.fish/4c3dd562-b077-477c-b9db-da03842e0953

@kb2ma kb2ma mentioned this issue Sep 1, 2022
Merged
@kb2ma kb2ma mentioned this issue Sep 20, 2022
Open
@ghost ghost closed this as completed in #2000 Oct 17, 2022
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
low-hanging fruit Easy to fix issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Allow most printable ASCII chars for service label key balena-os/balena-supervisor
2 participants
@pipex @jellyfish-bot