Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SDK does not handle request exceptions #144

Open
ejohnso49 opened this issue Apr 26, 2019 · 0 comments
Open

SDK does not handle request exceptions #144

ejohnso49 opened this issue Apr 26, 2019 · 0 comments

Comments

@ejohnso49
Copy link

When the SDK makes requests to the Balena API, it will not catch exceptions raised by the requests package. These exceptions then bubble up to the SDK client. I think it would be nice for the SDK to catch these and return something to the client to indicate the operation failed instead of not handling the exception. The instance I encountered was a call with balena.models.supervisor.reboot() resulting in a requests.exceptions.ReadTimeout.

@ejohnso49 ejohnso49 changed the title Requests that timeout raise exception from SDK SDK does not handle request exceptions Apr 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant